Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import ReSwiftThunkTesting via SPM #56

Open
mhamann opened this issue Nov 21, 2022 · 4 comments
Open

Cannot import ReSwiftThunkTesting via SPM #56

mhamann opened this issue Nov 21, 2022 · 4 comments

Comments

@mhamann
Copy link

mhamann commented Nov 21, 2022

I'm using ReSwiftThunk via SPM. In my test file, I try to import the testing helper like this:

import ReSwiftThunk
import ReSwiftThunkTesting

but when I do, Xcode shows the error No such module 'ReSwiftThunkTesting'.

This is an Xcode Project...not a pure Swift module, so not sure if that has anything to do with it.

@mhamann
Copy link
Author

mhamann commented Nov 21, 2022

Of course, as soon as I opened this, I discovered that the updates to the Package.swift file to include the testing library haven't been tagged as a proper version. See https://github.com/ReSwift/ReSwift-Thunk/blob/2.0.1/Package.swift

Any chance a v2.0.2 can be released to fix this?

@mhamann
Copy link
Author

mhamann commented Nov 21, 2022

Also, I think perhaps ReSwiftThunkTesting needs to declare a dependency on ReduxThunk?

@DivineDominion
Copy link
Contributor

DivineDominion commented Nov 26, 2022

@mhamann Thanks for reporting this! Could you test the package dependency locally and open a PR if changes need to be made? I can go ahead and create a tag when everything works 👍

@rei315
Copy link

rei315 commented Jan 18, 2023

Even with the master branch, There was a problem that ReSwift was not imported in the "ExpectThunk.swift"
Is there any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants