Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for CJ supporting complex number #6215

Closed
sandhya-davera opened this issue Jul 2, 2024 · 2 comments · Fixed by #6474
Closed

Update documentation for CJ supporting complex number #6215

sandhya-davera opened this issue Jul 2, 2024 · 2 comments · Fixed by #6474
Labels
documentation

Comments

@sandhya-davera
Copy link

In the documentation, pg no. 73, it says the function CJ "support for sorting complex is not yet implemented".
I expected to get a warning, but the sorting looks correct. It looks like it has been added in the pull request #3690. If the functionality is implemented, would it be possible to update the documentation to remove this comment: "support for sorting complex is not yet implemented"
@ben-schwen
Copy link
Member

ben-schwen commented Jul 2, 2024 •
edited
Loading

Good catch, ty for the report. Seems that #3691 added the current example and it wasn't updated when we started to support sorting complex with #3701

@MichaelChirico
Copy link
Member

thanks @sandhya-davera ! do you want to have a go at writing the PR?

@MichaelChirico MichaelChirico mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CJ example for sorted=FALSE Rdatatable/data.table
3 participants
@MichaelChirico @ben-schwen @sandhya-davera