From 336a73b0b39ed992ab77a1b94293fc6fb164cf82 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 22 Nov 2021 13:36:14 -0800 Subject: [PATCH 1/2] Remove gradle scan publishing from CI (#4689) * Remove gradle scan publishing from CI * Remove doc too --- CONTRIBUTING.md | 13 ------------- settings.gradle.kts | 12 +----------- 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8b7148227e56..17ea063ff05e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -65,16 +65,3 @@ See [Debugging](docs/contributing/debugging.md) ### Understanding Muzzle See [Understanding Muzzle](docs/contributing/muzzle.md) - -### Troubleshooting PR build failures - -The build logs are very long and there is a lot of parallelization, so the logs can be hard to -decipher, but if you scroll to the bottom you should see something like: - -``` -Publishing build scan... -https://gradle.com/s/ila4qwp5lcf5s -``` - -Opening the build scan link can sometimes take several seconds (it's a large build), but it -typically makes it a lot clearer what's failing. diff --git a/settings.gradle.kts b/settings.gradle.kts index 6f82e372b59d..a2a085290006 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -28,19 +28,9 @@ dependencyResolutionManagement { val gradleEnterpriseServer = "https://ge.opentelemetry.io" val isCI = System.getenv("CI") != null -val geAccessKey = System.getenv("GRADLE_ENTERPRISE_ACCESS_KEY") ?: "" - -// if GE access key is not given and we are in CI, then we publish to scans.gradle.com gradleEnterprise { - if (geAccessKey.isNotEmpty()) { - server = gradleEnterpriseServer - } + server = gradleEnterpriseServer buildScan { - // TODO remove this until legal approves - if (geAccessKey.isEmpty() && isCI) { - termsOfServiceUrl = "https://gradle.com/terms-of-service" - termsOfServiceAgree = "yes" - } publishAlways() this as com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures publishIfAuthenticated() From fac60ddb3c9d7f2f4851f6f4153c984db48361bc Mon Sep 17 00:00:00 2001 From: Lauri Tulmin Date: Tue, 23 Nov 2021 20:30:45 +0200 Subject: [PATCH 2/2] Enable read timeout test for HttpURLConnection (#4699) --- .../src/test/groovy/HttpUrlConnectionTest.groovy | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/instrumentation/http-url-connection/javaagent/src/test/groovy/HttpUrlConnectionTest.groovy b/instrumentation/http-url-connection/javaagent/src/test/groovy/HttpUrlConnectionTest.groovy index 83f610a4b9ee..11851435a917 100644 --- a/instrumentation/http-url-connection/javaagent/src/test/groovy/HttpUrlConnectionTest.groovy +++ b/instrumentation/http-url-connection/javaagent/src/test/groovy/HttpUrlConnectionTest.groovy @@ -27,6 +27,9 @@ class HttpUrlConnectionTest extends HttpClientTest implements @Override int sendRequest(HttpURLConnection connection, String method, URI uri, Map headers) { + if (uri.toString().contains("/read-timeout")) { + connection.readTimeout = READ_TIMEOUT_MS + } try { connection.setRequestMethod(method) headers.each { connection.setRequestProperty(it.key, it.value) } @@ -65,6 +68,11 @@ class HttpUrlConnectionTest extends HttpClientTest implements return false } + @Override + boolean testReadTimeout() { + true + } + @Unroll def "trace request (useCaches: #useCaches)"() { setup: