Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail properly if string is passed to parser instead of unicode #210

Closed
tmbo opened this issue Mar 11, 2017 · 0 comments · Fixed by #211
Closed

Fail properly if string is passed to parser instead of unicode #210

tmbo opened this issue Mar 11, 2017 · 0 comments · Fixed by #211
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@tmbo
Copy link
Member

tmbo commented Mar 11, 2017

If a a string instead of unicode is passed to the interpreter the interpreter will fail at random points with a type error ala:

TypeError: Argument 'string' has incorrect type (expected unicode, got str)

This should be properly handled right at the beginning of the parsing (either by converting to unicode or by rejecting the argument).
@tmbo tmbo added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Mar 11, 2017
@tmbo tmbo mentioned this issue Mar 13, 2017
Merged
2 tasks
@tmbo tmbo closed this as completed in #211 Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Component based architecture RasaHQ/rasa
1 participant
@tmbo