Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rasa data validate should fail if conflicting slots are created in different domain files #9555

Closed
3 tasks
hsm207 opened this issue Sep 6, 2021 · 1 comment · Fixed by #10444
Closed
3 tasks
Assignees
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework cse-issues effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@hsm207
Copy link
Contributor

hsm207 commented Sep 6, 2021

What problem are you trying to solve?

Users may split the domain.yml into multiple files and have different teams work on different domain.

I want rasa data validate to check and fail if there are duplicate intents, conflicting slots, etc across the split domain files.

For example:

  1. Run rasa init.
  2. Copy domain.yml to domain/domain1.yml.
  3. Delete domian.yml
  4. Add the following slots in domain/domain1.yml:
    image
  5. Create an empty file at domain/domain2.yml and write:
    image
  6. Run rasa data validate -d domain/.

The check will complete without errors

What's your suggested solution?

rasa data validate consolidates all the domain files and then runs the yaml validation check.

Examples (if relevant)

No response

Is anything blocking this from being implemented? (if relevant)

No response

Definition of Done

  • rasa data validate -d domain/ does not fail when conflicting/duplicate slots/intents/etc are found
  • Add an integration test to ensure this works as expected
  • Fixed merged into 2.8 and 3.0
@hsm207 hsm207 added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Sep 6, 2021
@TyDunn TyDunn added cse-issues area:rasa-oss/cli Issues focused on the rasa command-line-interface labels Sep 14, 2021
@hsm207 hsm207 added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Nov 11, 2021
@TyDunn
Copy link
Contributor

TyDunn commented Nov 12, 2021

The fix for this issue will need to be backported to the last minor of the previous major (i.e. Rasa Open Source 2.8)

@TyDunn TyDunn added priority:high type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. and removed type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework cse-issues effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
3 participants