Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Recipe to convert current config to GraphSchema #9277

Closed
4 tasks
wochinge opened this issue Aug 5, 2021 · 4 comments · Fixed by #9803
Closed
4 tasks

Implement Recipe to convert current config to GraphSchema #9277

wochinge opened this issue Aug 5, 2021 · 4 comments · Fixed by #9803
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. feature:rasa-3.0/architecture type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@wochinge
Copy link
Contributor

wochinge commented Aug 5, 2021

Overview of the Solution:
Implement the Recipe class which converts the current config to a train and predict GraphSchema using the given CLI params. This component loads all the classes and uses the @DefaultV1.register(...) decorator to create the graph structure from it.

See the implementation proposal for further details.

Blockers (if relevant):
Existing components needs to be adapted to new graph interface.

Definition of Done:

  • Recipe is tested with different configurations (default configuration, configurations with custom components / policies, auto configuration)
  • Recipe interface is implemented
  • all default Rasa Open Source components / policies are decorated with the @DefaultV1.register(...)
  • the configuration is validated
    • Check pipeline is not empty
    • Checks only one tokenizer is present
@wochinge wochinge added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework feature:rasa-3.0/architecture labels Aug 5, 2021
@TyDunn TyDunn added this to the 3.0 Rasa Open Source milestone Aug 5, 2021
@TyDunn TyDunn added the effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Aug 6, 2021
@wochinge
Copy link
Contributor Author

wochinge commented Aug 9, 2021

We could consider omitting Duckling (and other pretrained extractors) from the train_graph 🤔 See #3389 (comment) .

@wochinge
Copy link
Contributor Author

omit e2e featurization when we only train a core model

@m-vdb
Copy link
Collaborator

m-vdb commented Aug 16, 2021

@wochinge and @joejuzl to split this issue

@wochinge wochinge self-assigned this Aug 17, 2021
@wochinge wochinge linked a pull request Aug 23, 2021 that will close this issue
6 tasks
@wochinge
Copy link
Contributor Author

Moved this back to Backlog as the core functionality is implemented but now have to until all things have been changed to be GraphComponents before wrapping this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. feature:rasa-3.0/architecture type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
4 participants