Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Fix index #9048

Closed
2 tasks
twerkmeister opened this issue Jul 6, 2021 · 1 comment
Closed
2 tasks

mypy: Fix index #9048

twerkmeister opened this issue Jul 6, 2021 · 1 comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@twerkmeister
Copy link
Contributor

Maxime recently enabled mypy support for the first couple of issues. In our current setup we ignore certain typing issues as there are currently too many to tackle them all at once.

We should instead tackle them step by step. Related issue. Parent issue.

Current number of issues with this type: 36

Definition of Done:

  • enable mypy checks for index
  • all existing index issues are fixed
@twerkmeister twerkmeister added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 6, 2021
@wochinge
Copy link
Contributor

wochinge commented Jul 6, 2021

closed by #9043

@wochinge wochinge closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twerkmeister @wochinge