Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker featurization during batch generation #9022

Closed
5 tasks
twerkmeister opened this issue Jul 5, 2021 · 1 comment
Closed
5 tasks

Tracker featurization during batch generation #9022

twerkmeister opened this issue Jul 5, 2021 · 1 comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning research:end-to-end type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@twerkmeister
Copy link
Contributor

twerkmeister commented Jul 5, 2021

Description of Problem: Currently every tracker is featurized before the training and kept around in memory. This takes a lot of time, but also a lot of memory, keeping all the featurized trackers around at the same time. This issue is particularly big for large e2e datasets such as multiwoz.

Overview of the Solution: The trackers can be featurized during the batch generation. This leads to much lower memory consumption. However, featurization from the ground up is slower than the model training loop. This is why this issue first needs the lookup table issue to be resolved to be viable.

There is a prototypical implementation of this feature in the combined e2e fixes branch where the trackers are encoded inside the data loader class.

Open Issues

  • Entity recognition does not work yet in the prototypical implementation

Blockers #9020 is needed for this proposal to be computationally viable

Definition of Done:

  • Harmonize current prototypical implementation with the new architecture prototype
  • Make code quality production ready
  • Add memory / runtime test to confirm working
  • training with entities works
  • Feature mentioned in the changelog
@twerkmeister twerkmeister added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning research:end-to-end labels Jul 5, 2021
@rasabot-exalate rasabot-exalate added area:rasa-oss and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning labels Mar 15, 2022 — with Exalate Issue Sync
@m-vdb m-vdb added area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning and removed area:rasa-oss labels Mar 16, 2022
@rasabot rasabot added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed type:enhancement labels Mar 16, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning area:rasa-oss labels Mar 17, 2022 — with Exalate Issue Sync
@rasabot-exalate rasabot-exalate added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Mar 21, 2022 — with Exalate Issue Sync
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning research:end-to-end type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

4 participants