Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrainingDataExporter #4584

Closed
wochinge opened this issue Oct 9, 2019 · 3 comments
Closed

TrainingDataExporter #4584

wochinge opened this issue Oct 9, 2019 · 3 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

wochinge commented Oct 9, 2019

I propose a component TrainingDataExporter which mirrors the TrainingDataImporter.

class TrainingDataExporter:

 @staticmethod
 def save_domain(domain: Domain, path: Text) -> None:
 pass

 @staticmethod
 def save_training_data(training_data: TrainingData, path: Text) -> None:
 pass

 @staticmethod
 def save_stories(stories: List[Story], path: Text) -> None:
 pass

 @staticmethod
 def save_config(config: Dict, path: Text) -> None:
 pass

Goals:

  • have the option to change the export behavior globally
  • users should be able to implement their own module for exporting data
  • we should move out the persistence stuff out of our domain objects (improves encapsulation)

Implementations:

  • one which exports markdown / yaml
  • one which overwrites the last one and exports NLU as json
@wochinge wochinge added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. labels Oct 9, 2019
@imLew
Copy link
Contributor

imLew commented Oct 15, 2019

How would this be used? Since the data is already very accessible I imagine this would mainly be a tool that converts between different formats. I definitely like the idea of allowing users to have their own format!

Why put it in the config.yml though? My understanding is that that is config for the actual bot. If we have more tools like this that are project specific but not bot specific we should consider having a project-config somewhere.

@wochinge
Copy link
Contributor Author

Why put it in the config.yml though?

Good point. Currently that's slowly diverging from a bot-config to a general config (DataImporter is also using that). I'm personally not a huge fan of having even more files in a rasa project than we have now, but I see your point.

How would this be used? Since the data is already very accessible I imagine this would mainly be a tool that converts between different formats. I definitely like the idea of allowing users to have their own format!

That's what I wrote in the goals.

  • converting between the data
  • making our entity objects / modules leaner

I imagine to configure that in a config and when I use rasa or even rasa x then it would dump data in the specified format.

@wochinge
Copy link
Contributor Author

re-opening this after the short discussion in #6323

@wochinge wochinge reopened this Aug 17, 2020
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. and removed type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. labels Aug 17, 2020
@alwx alwx added area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Jan 28, 2021
@rasabot-exalate rasabot-exalate added type:maintenance_:wrench: type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. type:maintenance_:wrench: labels Mar 17, 2022 — with Exalate Issue Sync
@m-vdb m-vdb closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

No branches or pull requests

5 participants