remove _warn_and_correct_transformer_size as it's not needed anymore

[jupyterjazz]

What's the purpose of this function? As the name suggests, _warn_and_correct_transformer_size corrects transformer_size parameter value in ResponseSelector and warns developers about this.

transformer_size is None by default. Hence, in case transformer layers are used inside ResponseSelector but transformer_size isn't specified in the config, we can't leave it to None and we correct it to a constant integer value.

Why should we remove it? The problem is that _warn_and_correct_transformer_size is only called during training. #10519 showed us that we need to correct the parameter during loading as well. #10651 solved the error by modifying this function

rasa/rasa/utils/tensorflow/rasa_layers.py

Line 795 in e522be7

def _get_transformer_dimensions(

which is called during both training and prediction(loading). Thus, _warn_and_correct_transformer_size isn't needed anymore.

Definition of Done

• Remove _warn_and_correct_transformer_size and resolve failing tests caused by the removal
• Move warning into

  rasa/rasa/utils/tensorflow/rasa_layers.py

  Line 795 in e522be7

  def _get_transformer_dimensions(

[emysdias]

Exalate commented:

emysdias commented:

Hello there, I would like to work on this issue, can I?

[jupyterjazz]

Exalate commented:

jupyterjazz commented:

Hi @emysdias, please go ahead and put me as a reviewer when you make a PR

[emysdias]

Exalate commented:

emysdias commented:

Hi @emysdias, please go ahead and put me as a reviewer when you make a PR

ok, thanks

[sync-by-unito]

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.