Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanic version incompatible with Rasa #10632

Closed
1 of 2 tasks
tayfun opened this issue Jan 5, 2022 · 3 comments
Closed
1 of 2 tasks

Sanic version incompatible with Rasa #10632

tayfun opened this issue Jan 5, 2022 · 3 comments
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@tayfun
Copy link
Contributor

tayfun commented Jan 5, 2022

Rasa Open Source version

3.0.x

Rasa SDK version

No response

Rasa X version

No response

Python version

3.8

What operating system are you using?

OSX

What happened?

We have a ticket showing new Sanic versions which are compatible with pyproject.toml breaking rasa-sdk. In addition to that, I find we have other incompatibilities with rasa. Currently we have sanic = "^21.6.0" in pyproject.toml file. In pypi we don't use lock files, poetry.lock file is for local dev only. If I update requirements and run shell, I get import error on CompositionView.

poetry update

Results in Sanic being upgraded to 21.12.0 from 21.9.3. When I run shell, I get following exception (app name exception should come later):

$ rasa shell --help
Traceback (most recent call last):
  File "/Users/tayfun/.virtualenvs/rasa3.0/bin/rasa", line 2, in <module>
    from rasa.__main__ import main
  File "/Users/tayfun/w/rasa/rasa/__main__.py", line 14, in <module>
    from rasa.cli import (
  File "/Users/tayfun/w/rasa/rasa/cli/export.py", line 9, in <module>
    import rasa.core.utils
  File "/Users/tayfun/w/rasa/rasa/core/utils.py", line 25, in <module>
    from sanic.views import CompositionView
ImportError: cannot import name 'CompositionView' from 'sanic.views' (/Users/tayfun/.virtualenvs/rasa3.0/lib/python3.8/site-packages/sanic/views.py)

Once https://github.com/RasaHQ/rasa/pull/10590/files is merged, check shell run again and see if Sanic name should be updated to be without any dots. After fixing Sanic app name, we should also check any other incompatibilities. If too many, we can also pin down Sanic in pyproject, but this has to be consistent with rasa-sdk.

Command / Request

No response

Relevant log output

No response

Definition of done

@tayfun tayfun added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jan 5, 2022
@TyDunn TyDunn added the effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Jan 7, 2022
@koaning
Copy link
Contributor

koaning commented Jan 10, 2022

This is potentially a duplicate of #10585

@koaning
Copy link
Contributor

koaning commented Jan 26, 2022

I just saw this bug re-appear on Rasa Open Source 3.0.5, despite the suggested fix in #10590.

@tayfun
Copy link
Contributor Author

tayfun commented Jan 27, 2022

I just saw this bug re-appear on Rasa Open Source 3.0.5, despite the suggested fix in #10590.

We forgot to backport to 3.0.x :D here's PR for it https://github.com/RasaHQ/rasa/pull/10762/files

@TyDunn TyDunn closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

4 participants