Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a plan to add support for reading other recipes #10402

Closed
2 tasks done
TyDunn opened this issue Nov 26, 2021 · 1 comment
Closed
2 tasks done

Create a plan to add support for reading other recipes #10402

TyDunn opened this issue Nov 26, 2021 · 1 comment
Assignees
@tayfun @joejuzl
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. feature:rasa-3.0/architecture type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@TyDunn
Copy link
Contributor

TyDunn commented Nov 26, 2021 •
edited by tayfun
Loading

It’s currently not possible to simply write your own, custom Recipe and use that to train a Rasa model. The reasons are the location of where we do the suggested config and a couple of places where we currently validate the config format. We'd need to move the autoconfig within the recipes and drop _get_valid_config. Context here.

Definition of done

  • Draft proposal for how to do this
  • Create issue to do this
@TyDunn TyDunn added area:rasa-oss 🎡 Anything related to the open source Rasa framework feature:rasa-3.0/architecture type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR priority:high effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. labels Nov 26, 2021
@tayfun
Copy link
Contributor

tayfun commented Dec 7, 2021

Created #10473 for this ticket. Proposal document here: https://www.notion.so/rasa/Proposal-to-support-reading-other-recipes-WIP-f46c596c580e480f9af6e74284e8621b (ask Joe or Tayfun for permission if you can't access it)

@tayfun tayfun closed this as completed Dec 7, 2021
@tayfun tayfun changed the title Add support for reading other recipes Create a plan to add support for reading other recipes Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tayfun tayfun

@joejuzl joejuzl

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. feature:rasa-3.0/architecture type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tayfun @joejuzl @TyDunn