Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprocess "overlay-sidecar.exe" might have memory leak #76

Open
camegone opened this issue Mar 8, 2024 · 6 comments
Open

Subprocess "overlay-sidecar.exe" might have memory leak #76

camegone opened this issue Mar 8, 2024 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@camegone
Copy link

camegone commented Mar 8, 2024

Sometimes process called "overlay-sidecar.exe" eat up entire RAM on a machine.
I activated "Memory Watcher" feature, then popup window alert constantly spams.
image

@Raphiiko
Copy link
Owner

Raphiiko commented Mar 8, 2024

Thanks for reporting. That's very odd. Although there have been memory issues in the past, none of them have happened in the overlay module yet. The next time this happens, would you mind sharing your log file with me? You'll be able to find it at %APPDATA%\co.raphii.oyasumi\logs\OyasumiSidecar.log.

In the meantime, I'll see if I can add some useful memory profiling to the overlay module in an upcoming release.

@camegone
Copy link
Author

I'll attach OyasumiSidecar_20240308.log, which should be a log file contains the event, instead, since the specified file seems not be written recently.
OyasumiVR_Overlay_Sidecar_20240308.log

In my environment, overlay-sidecar,exe consumes over 1.7 GB of memory as soon as I launch Oyasumi VR application, and I can see the RAM usage goes up slowly. Changing brightness on the app, RAM usage seems to go up by a some hundreds KB.

@Raphiiko
Copy link
Owner

Raphiiko commented Mar 13, 2024

Gotcha. The logs sadly don't say much. The ram usage increasing a bit when you change brightness is expected, but that initial 1.7GB really shouldn't be happening. Here the overlay uses about 80MB after starting, with SteamVR running.

  • Is there a difference in memory use between launching OyasumiVR with SteamVR already running, and without SteamVR already running? (And does this changes when you launch SteamVR after?)
  • Could you try and see if this happens on the new beta version? You can get it by switching to the beta branch on Steam, and then optionally verifying integrity on your install files. You'll know you're on the right build if you find the build number d3e2a0c in the about view.

@camegone
Copy link
Author

  1. There is no difference between with or without Steam VR already running.
  2. Beta build d3e2a0c seems not solved this problem; it still consume 1.7GB of RAM...

Additionally, I found that opening overlay menu in VR cause massive memory usage increase (about 500MB/s).

@Raphiiko Raphiiko assigned Raphiiko and unassigned Raphiiko Apr 10, 2024
@Raphiiko Raphiiko added bug Something isn't working help wanted Extra attention is needed labels Apr 10, 2024
@Raphiiko
Copy link
Owner

I seem to have absolutely no way of reproducing this, so I sadly cannot do much about it currently.

I'll leave this issue open in case more people are experiencing this, or maybe get some insights from someone who knows why it might be happening.

@Raphiiko
Copy link
Owner

Raphiiko commented Aug 16, 2024

If someone happens to run into this, please send me a memory dump on Discord (before killing the overlay)

You can just right click the overlay-sidecar.exe process in task manager, and click "Create memory dump file"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants