-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm which versions are compatibile in pyproject #6
Comments
Does this fix work for you? |
It would, but I think we should be a little careful and do a batch of test each new release of rdkit with a larger list of polymers. So set up would be:
What do you think of this idea? I think we could automate testing process by saving a list of tested rdkit version and only testing newly released version, and then if we didn't want to spend time on step 4, we could just make sure people were aware of the issue on the README |
This sounds good to me. But, RDKit's core functions that I use should be very stable, and I hope there aren't too many changes affecting this. |
Currently, packages that depend on this package cannot use rdkit versions past year 2022 due to the fact that poetry follows
major.minor.patch
semantic versioning by default. I propose adding pytests to this folder and then as new rdkit versions are released testing if they are compatible and adjusting rdkit version in pypoetry with>=2022.3.5,<=year.month.date
.Because polyvfs depends on canonicalize-psmiles (0.1.1) @ git+ssh://[email protected]/Ramprasad-Group/[email protected] which depends on rdkit (^2022.3.5), rdkit is required. So, because polyvfs depends on rdkit (^2023.3.2), version solving failed.
I am happy to do this myself @kuelumbus
The text was updated successfully, but these errors were encountered: