Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy search visualization glitch #62

Closed
MisterTimn opened this issue Nov 8, 2024 · 1 comment · Fixed by #64
Closed

Fuzzy search visualization glitch #62

MisterTimn opened this issue Nov 8, 2024 · 1 comment · Fixed by #64

Comments

@MisterTimn
Copy link

Describe the bug
When using fuzzy search to find context or namespace, selecting with arrows works fine, but when you start to search by typing the visualization glitches:

To Reproduce

  1. enter kubesess context or kubesess namespace
  2. start typing to search
  3. Search works fine but the visualization glitches (letters arent cleared properly)

Expected behavior
See visual of clear screen with only the search hits visible, not floating characters (like fzf)

Screenshots
image

Desktop (please complete the following information):

  • OS: Fedora
  • Kubesess Version 2.0.1
  • Shell: zsh (also tested in bash shell)
  • Terminal: tested in both Gnome terminal and Alacritty

Additional context
I see the tool opted to use an own implementation of fuzzy searching instead of relying on fzf, perhaps it's this more recent change?

@Ramilito
Copy link
Owner

Ramilito commented Nov 8, 2024

Should be fixed in #64! I updated the version for skim (the crate that does the fuzzy search) and I don't see any ui glitching anymore!
Reopen this issue if you are still experiencing issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants