Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests, use globals and simplify script #21

Closed
Ramilito opened this issue Aug 31, 2022 · 0 comments
Closed

Add tests, use globals and simplify script #21

Ramilito opened this issue Aug 31, 2022 · 0 comments

Comments

@Ramilito
Copy link
Owner

Ramilito commented Aug 31, 2022

Is your feature request related to a problem? Please describe.

Need tests to trust PR:s
Simplify passing arguments around with globals
The script is responsible for pre-pending environment variable, do it in-app instead so it's testable

Describe the solution you'd like

Use lazy_static for globals
Use tests that calls the binary and validates the output

Describe alternatives you've considered

Not testing and implementing bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant