Update csiaddons to v0.5.0 & point volrep to csiaddons #534

Rakshith-R · 2022-09-07T09:34:35Z

This commit updates csiaddons to v0.5.0 and other deps. This also points volrep to kubernetes-csi-addons repo now.

Signed-off-by: Rakshith R [email protected]

Rakshith-R · 2022-09-07T09:39:54Z

/cc @rakeshgm @ShyamsundarR @Madhu-1

Madhu-1

PR is having formating changes and other go mod updates also. please try to keep the change minimal

Madhu-1 · 2022-09-07T10:33:10Z

controllers/drcluster_controller.go

@@ -313,17 +313,17 @@ func (u *drclusterInstance) finalizerRemove() error {
 }

 // TODO:
-// 1) For now by default fenceStatus is ClusterFenceStateUnfenced.


This is not related to this PR please revert.

Madhu-1

LGTM expected few go.mod changes

Madhu-1 · 2022-09-07T10:53:27Z

go.mod

+	k8s.io/api v0.25.0
+	k8s.io/apimachinery v0.25.0


there are a few updates to use Kubernetes 0.25, not sure it can cause any problem, let @ShyamsundarR confirm on it.

This is replaced below,

This automatically done when csi-addons was updated.

ShyamsundarR · 2022-09-07T12:40:32Z

go.mod

+	k8s.io/apimachinery => k8s.io/apimachinery v0.23.6
+	k8s.io/client-go => k8s.io/client-go v0.23.6
+	k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20220124234850-424119656bbf
+	sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.11.2


Other than controller-runtime the other replace directives are to ensure ramen sticks to existing versions of these dependencies? Or, was this required for other reasons?

I typically do not want additional replace clauses, unless required. The controller-runtime is fine, so that we can catch up to the latest and remove the replace clause as time permits.

The build and golangci is failing,
after normal
go get and go mod tidy

weirdly it is asking for login to github.ibm.com in my vscode, not sure why.

ShyamsundarR · 2022-09-08T11:51:45Z

go.mod

 	sigs.k8s.io/yaml v1.3.0 // indirect
 )

-replace k8s.io/client-go => k8s.io/client-go v0.23.6
+replace k8s.io/client-go => k8s.io/client-go v0.25.0


Thank you for clearing this section up.

Thank you for clearing this section up.

It was a challenge figuring out what went wrong with the builds.
golangci linter needed update too in .github/workflow,
can you please trigger workflow again ?

This commit updates csiaddons to v0.5.0 and other deps. This also points volrep to kubernetes-csi-addons repo now. Signed-off-by: Rakshith R <[email protected]>

Rakshith-R · 2022-09-08T12:18:49Z

https://github.com/RamenDR/ramen/runs/8248656188?check_suite_focus=true

go get does not work anymore,
changed it to go install

Signed-off-by: Rakshith R <[email protected]>

Rakshith-R · 2022-09-08T13:04:16Z

Updated kustomize and handled the errors it threw
kubeflow/manifests#1797 (comment)

Rakshith-R · 2022-09-09T05:58:59Z

@Madhu-1 @ShyamsundarR Please take a look
ci is green.

Madhu-1

changes LGTM, We need to update the build team to use go 1.18 to build ramen in downstream.

ShyamsundarR · 2022-09-09T12:41:57Z

config/crd/bases/ramendr.openshift.io_drclusters.yaml

@@ -77,8 +77,8 @@ spec:
                  description: "Condition contains details for one aspect of the current
                    state of this API Resource. --- This struct is intended for direct
                    use as an array at the field path .status.conditions.  For example,
-                    type FooStatus struct{ // Represents the observations of a foo's
-                    current state. // Known .status.conditions.type are: \"Available\",
+                    \n type FooStatus struct{ // Represents the observations of a


Why were these new lines required? Or were these auto generated by make manifests?

ShyamsundarR · 2022-09-09T12:45:32Z

config/dr-cluster/default/kustomization.yaml

+- ../crd
+- ../rbac
+- ../manager
+images:


Is this autogenerated?

ShyamsundarR · 2022-09-09T12:49:40Z

.golangci.yaml

@@ -58,3 +58,26 @@ linters:
    - goheader  # TODO: Introduce back post fixing linter errors
    - gci
    - interfacer  # interfacer linter is archived and deprecated (https://github.com/mvdan/interfacer)
+    # TODO: fix folloing linter errors.


Are these new linters as compared to prior version v1.37.1 -> v1.49.0 of golang? If existing linters are being disabled, we would like to track and add them back, hence checking.

Typo folloing to following

ShyamsundarR · 2022-09-09T13:41:38Z

Merging this as is, the linter changes we will look at and rectify if required.

Madhu-1 requested changes Sep 7, 2022

View reviewed changes

Rakshith-R force-pushed the change-volrep-src branch from e00aef2 to af30f7d Compare September 7, 2022 10:51

Rakshith-R requested a review from Madhu-1 September 7, 2022 10:52

Madhu-1 reviewed Sep 7, 2022

View reviewed changes

ShyamsundarR reviewed Sep 7, 2022

View reviewed changes

Rakshith-R force-pushed the change-volrep-src branch 2 times, most recently from 3092913 to 9378e60 Compare September 8, 2022 11:46

Rakshith-R requested a review from ShyamsundarR September 8, 2022 11:46

Rakshith-R force-pushed the change-volrep-src branch from 9378e60 to 27f0a81 Compare September 8, 2022 11:48

ShyamsundarR reviewed Sep 8, 2022

View reviewed changes

Rakshith-R force-pushed the change-volrep-src branch from 27f0a81 to a79738e Compare September 8, 2022 11:53

Rakshith-R requested review from Madhu-1 and ShyamsundarR and removed request for Madhu-1 and ShyamsundarR September 8, 2022 11:59

Update csiaddons to v0.5.0 & point volrep to csiaddons

440716f

This commit updates csiaddons to v0.5.0 and other deps. This also points volrep to kubernetes-csi-addons repo now. Signed-off-by: Rakshith R <[email protected]>

Rakshith-R force-pushed the change-volrep-src branch from a79738e to 440716f Compare September 8, 2022 12:18

rebase: update kustomize and make necessary changes

fcebda2

Signed-off-by: Rakshith R <[email protected]>

Rakshith-R requested review from ShyamsundarR and Madhu-1 and removed request for Madhu-1 and ShyamsundarR September 8, 2022 13:32

Madhu-1 approved these changes Sep 9, 2022

View reviewed changes

Madhu-1 requested a review from ShyamsundarR September 9, 2022 06:12

ShyamsundarR reviewed Sep 9, 2022

View reviewed changes

ShyamsundarR merged commit 2122d76 into RamenDR:main Sep 9, 2022

ShyamsundarR mentioned this pull request Jul 5, 2023

Disable unhelpful linters #957

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update csiaddons to v0.5.0 & point volrep to csiaddons #534

Update csiaddons to v0.5.0 & point volrep to csiaddons #534

Rakshith-R commented Sep 7, 2022

Rakshith-R commented Sep 7, 2022

Madhu-1 left a comment

Madhu-1 Sep 7, 2022

Madhu-1 left a comment

Madhu-1 Sep 7, 2022

Rakshith-R Sep 7, 2022

ShyamsundarR Sep 7, 2022

Rakshith-R Sep 7, 2022

ShyamsundarR Sep 8, 2022

Rakshith-R Sep 8, 2022

Rakshith-R commented Sep 8, 2022

Rakshith-R commented Sep 8, 2022

Rakshith-R commented Sep 9, 2022

Madhu-1 left a comment

ShyamsundarR Sep 9, 2022

ShyamsundarR Sep 9, 2022

ShyamsundarR Sep 9, 2022

Madhu-1 Sep 9, 2022

ShyamsundarR commented Sep 9, 2022

Update csiaddons to v0.5.0 & point volrep to csiaddons #534

Update csiaddons to v0.5.0 & point volrep to csiaddons #534

Conversation

Rakshith-R commented Sep 7, 2022

Rakshith-R commented Sep 7, 2022

Madhu-1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Madhu-1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rakshith-R commented Sep 8, 2022

Rakshith-R commented Sep 8, 2022

Rakshith-R commented Sep 9, 2022

Madhu-1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShyamsundarR commented Sep 9, 2022