Skip to content

Commit

Permalink
Auto merge of #117138 - zachs18:rwlock_guard_debug_unsized, r=dtolnay
Browse files Browse the repository at this point in the history
Add T: ?Sized to `RwLockReadGuard` and `RwLockWriteGuard`'s Debug impls.

For context, `MutexGuard` has `+ ?Sized` on its `Debug` impl, and all three have `+ ?Sized` on their `Display` impls.

It looks like the `?Sized` was just missed when the impls were added (the impl for `MutexGuard` was added in the same PR (rust-lang/rust#38006) with support for `T: Debug + ?Sized`, and `RwLock*Guard`s did allow `T: ?Sized` types already); the `Display` impls were added later (rust-lang/rust#42822) with support for `T: Debug + ?Sized` types.

I think this needs a T-libs-api FCP? I'm not sure if this also needs an ACP. If so I can make one.

These are changes to (stable) trait impls on stable types so will be insta-stable.

`@rustbot` label +T-libs-api
  • Loading branch information
bors committed Nov 18, 2023
2 parents a13f2b6 + 9be5606 commit bdff384
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit bdff384

Please sign in to comment.