Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rom update messages upsert #476

Merged
merged 16 commits into from
Dec 31, 2018
Merged

Conversation

joelvh
Copy link
Contributor

@joelvh joelvh commented Oct 15, 2018

This adds overwrite capability to the ROM adapter. Supercedes #463 to use UPSERT instead of batch UPDATE statements.

@joelvh joelvh requested a review from mostlyobvious October 15, 2018 04:03
@joelvh joelvh mentioned this pull request Dec 9, 2018
@joelvh joelvh force-pushed the feature/rom_update_messages_upsert branch from b0acae9 to 5ffcc57 Compare December 9, 2018 19:48
@joelvh joelvh force-pushed the feature/rom_update_messages_upsert branch from 5ffcc57 to 4467366 Compare December 29, 2018 10:23
@joelvh joelvh force-pushed the feature/rom_update_messages_upsert branch from 4467366 to 65be98a Compare December 29, 2018 22:06
@joelvh
Copy link
Contributor Author

joelvh commented Dec 29, 2018

@paneq @pawelpacana how do we specify to install Sqlite 3.24+ on TravisCI for upsert capability?

@joelvh
Copy link
Contributor Author

joelvh commented Dec 31, 2018

@paneq @pawelpacana saw that you're skipping tests for sqlite. Got things working and merging to master.

@joelvh joelvh merged commit 9e7c195 into master Dec 31, 2018
@joelvh joelvh deleted the feature/rom_update_messages_upsert branch December 31, 2018 01:54
@mostlyobvious
Copy link
Member

saw that you're skipping tests for sqlite. Got things working and merging to master

I'm glad it worked! There's an open issue to support sqlite (#446) which is why test might have been skipped.

We've moved most of the tests to CircleCI (some still left on TravisCI) and those run on docker images based on CircleCI ones. They have sqlite in version 3.16.2-5+deb9u1. If you know how to add sqlite 3.26 to Debian Stretch I could push new images.

@joelvh
Copy link
Contributor Author

joelvh commented Jan 3, 2019

@pawelpacana Looks like they released support in v0.26.0 of AR Import (based on the comment on zdennis/activerecord-import#540 (comment)

I opted to detect whether Sqlite 3.24.0+ is being used, otherwise throw an exception when using the overwrite feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants