Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing specs #118

Open
adamtao opened this issue Apr 14, 2015 · 3 comments
Open

Failing specs #118

adamtao opened this issue Apr 14, 2015 · 3 comments

Comments

@adamtao
Copy link

adamtao commented Apr 14, 2015

Thanks for compiling this starter app. The specs are mostly failing for me. It seems the last database migration removes the "name" column for users, but the user factory still has that field. Also, app/views/users/show.html.erb attempts to display the name attribute.

I know you've been working on updating this application for rails 4.2, so I apologize if I'm reporting something you already know about. I'd be glad to help resolve this issue if you can use an extra hand. I'd just need to understand the reasoning behind removing the name column. Maybe it should just be added back in. If not, the factory/specs/views likely need updating.

Thanks!

@DanielKehoe
Copy link
Member

Thanks for offering to help with the tests. It'd be great if you can contribute tests. I haven't done any work on tests yet. Please fork and contribute small, granular changes that I can easily review.

The name column only served to illustrate how to add a field when using Devise in the simpler starter apps. It seems that a name column is not desirable for a membership app since it is just extra info that is unnecessary.

@kathyonu
Copy link
Contributor

@adamtao : This note replaced with my next comment.

@kathyonu
Copy link
Contributor

kathyonu commented Jul 1, 2015

@adamtao : Please see PR Testsformaster #150 . I invite you to pull this branch into your working app, and take it for a spin. The four pending tests are related to Issue #116. I believe the problem I ran into is the same, in terms of not knowing how to get the stripe_token into the payola processings. I am asking everyone for help resolving the four pendings, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants