Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default output validator error margin #409

Open
RagnarGrootKoerkamp opened this issue Nov 12, 2024 · 2 comments
Open

default output validator error margin #409

RagnarGrootKoerkamp opened this issue Nov 12, 2024 · 2 comments

Comments

@RagnarGrootKoerkamp
Copy link
Owner

In the default output validator, when the float (absolute/relative) error is given as epsilon, we should probably use epsilon * (1 + 0.01) or so in practice, to avoid rejecting submissions that are only just below epsilon away from the correct answer.

We should also check what the DOMjudge/Kattis default output validators do and make this consistent maybe.

@mzuenni
Copy link
Collaborator

mzuenni commented Nov 12, 2024

right now we should be identical to domjudge

@mpsijm
Copy link
Collaborator

mpsijm commented Nov 12, 2024

For reference: that's this file, but it looks like this has been updated since we last synced:

https://github.com/DOMjudge/domjudge/blob/main/sql/files/defaultdata/compare/compare.cc

DOMjudge also does not have an extra "error on top of the allowed error". I think it's fine if we keep it like this, because typical submissions should not get close to the error that we permit anyway – this only matters for the jury submissions that very crudely add a constant 10¯⁶ on top of the actual answer for the purpose of testing the validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants