From 0fc2f21e2ad9e59bedca161d8c2cb09b5ad11b40 Mon Sep 17 00:00:00 2001 From: Radu Berinde Date: Fri, 30 Jun 2023 07:57:37 -0700 Subject: [PATCH] release-23.1: go.mod: bump Pebble to c0a2ede2b215d5512c4e39a824b6534f598cb059 c0a2ede2 db: improve delete pacing (https://github.com/cockroachdb/pebble/pull/2696) Informs #2662. Release justification: fixes very high goroutine count on heavy write workloads with fast disks. Release note (bug fix): On heavy write workloads with fast disks, the deletion of obsolete LSM files could fall behind, causing high goroutine count. Pacing of obsolete file deletion now adapts based on recent deletion rate to avoid falling behind. --- DEPS.bzl | 6 +++--- build/bazelutil/distdir_files.bzl | 2 +- go.mod | 2 +- go.sum | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/DEPS.bzl b/DEPS.bzl index d2203deab0fa..7e59a3a63f37 100644 --- a/DEPS.bzl +++ b/DEPS.bzl @@ -1555,10 +1555,10 @@ def go_deps(): patches = [ "@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch", ], - sha256 = "23ac3a157dfad798e30278ebeb36178490b75660a0696067ecfdc4a0c240252a", - strip_prefix = "github.com/cockroachdb/pebble@v0.0.0-20230622153957-b71662e4900e", + sha256 = "e1559cd36f6a903470b8547242c04f54a5188b6e2f67e7e618c7bb6308ea7865", + strip_prefix = "github.com/cockroachdb/pebble@v0.0.0-20230630143906-c0a2ede2b215", urls = [ - "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230622153957-b71662e4900e.zip", + "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230630143906-c0a2ede2b215.zip", ], ) go_repository( diff --git a/build/bazelutil/distdir_files.bzl b/build/bazelutil/distdir_files.bzl index 0c2913480de4..3b84dfa71c05 100644 --- a/build/bazelutil/distdir_files.bzl +++ b/build/bazelutil/distdir_files.bzl @@ -311,7 +311,7 @@ DISTDIR_FILES = { "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/go-test-teamcity/com_github_cockroachdb_go_test_teamcity-v0.0.0-20191211140407-cff980ad0a55.zip": "bac30148e525b79d004da84d16453ddd2d5cd20528e9187f1d7dac708335674b", "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/gostdlib/com_github_cockroachdb_gostdlib-v1.19.0.zip": "c4d516bcfe8c07b6fc09b8a9a07a95065b36c2855627cb3514e40c98f872b69e", "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/logtags/com_github_cockroachdb_logtags-v0.0.0-20230118201751-21c54148d20b.zip": "ca7776f47e5fecb4c495490a679036bfc29d95bd7625290cfdb9abb0baf97476", - "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230622153957-b71662e4900e.zip": "23ac3a157dfad798e30278ebeb36178490b75660a0696067ecfdc4a0c240252a", + "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230630143906-c0a2ede2b215.zip": "e1559cd36f6a903470b8547242c04f54a5188b6e2f67e7e618c7bb6308ea7865", "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/raft/v3/com_github_cockroachdb_raft_v3-v3.0.0-20230615130413-b160e656b5ae.zip": "74e17997c6fce06823600d9f69cdf49f330fbc89515dc35d04b1059f32eed93a", "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/redact/com_github_cockroachdb_redact-v1.1.4.zip": "9a723dfbb1627ae2f2b5d1374a59d6188ae9796e6dfb9a4622a4eb94321a4fac", "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/returncheck/com_github_cockroachdb_returncheck-v0.0.0-20200612231554-92cdbca611dd.zip": "ce92ba4352deec995b1f2eecf16eba7f5d51f5aa245a1c362dfe24c83d31f82b", diff --git a/go.mod b/go.mod index 04141a9ff23f..75b3dbf85579 100644 --- a/go.mod +++ b/go.mod @@ -115,7 +115,7 @@ require ( github.com/cockroachdb/go-test-teamcity v0.0.0-20191211140407-cff980ad0a55 github.com/cockroachdb/gostdlib v1.19.0 github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b - github.com/cockroachdb/pebble v0.0.0-20230622153957-b71662e4900e + github.com/cockroachdb/pebble v0.0.0-20230630143906-c0a2ede2b215 github.com/cockroachdb/redact v1.1.4 github.com/cockroachdb/returncheck v0.0.0-20200612231554-92cdbca611dd github.com/cockroachdb/stress v0.0.0-20220803192808-1806698b1b7b diff --git a/go.sum b/go.sum index f0844ffd9dce..29aa8e9589ed 100644 --- a/go.sum +++ b/go.sum @@ -479,8 +479,8 @@ github.com/cockroachdb/gostdlib v1.19.0/go.mod h1:+dqqpARXbE/gRDEhCak6dm0l14AaTy github.com/cockroachdb/logtags v0.0.0-20211118104740-dabe8e521a4f/go.mod h1:Vz9DsVWQQhf3vs21MhPMZpMGSht7O/2vFW2xusFUVOs= github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b h1:r6VH0faHjZeQy818SGhaone5OnYfxFR/+AzdY3sf5aE= github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b/go.mod h1:Vz9DsVWQQhf3vs21MhPMZpMGSht7O/2vFW2xusFUVOs= -github.com/cockroachdb/pebble v0.0.0-20230622153957-b71662e4900e h1:MpLjTbJsrCjcJOOO/DG10yswfMmOSoYg1OKvnnlpoYI= -github.com/cockroachdb/pebble v0.0.0-20230622153957-b71662e4900e/go.mod h1:9lRMC4XN3/BLPtIp6kAKwIaHu369NOf2rMucPzipz50= +github.com/cockroachdb/pebble v0.0.0-20230630143906-c0a2ede2b215 h1:htsd7PZUUmpq3afLmt5trLGmo8V5Ic/QERVqCg73Ix4= +github.com/cockroachdb/pebble v0.0.0-20230630143906-c0a2ede2b215/go.mod h1:9lRMC4XN3/BLPtIp6kAKwIaHu369NOf2rMucPzipz50= github.com/cockroachdb/raft/v3 v3.0.0-20230615130413-b160e656b5ae h1:Xx2f9+XlVGiD0HTM5nTW4AF3q4grd8J6RDcRMVXC6tA= github.com/cockroachdb/raft/v3 v3.0.0-20230615130413-b160e656b5ae/go.mod h1:xa/jfCF4K9FpWEAXstT+Nw4ToWdmhJ8oeC5eburtypA= github.com/cockroachdb/redact v1.1.3/go.mod h1:BVNblN9mBWFyMyqK1k3AAiSxhvhfK2oOZZ2lK+dpvRg=