forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
process: mark process.env as side-effect-free
Read-only access to `process.env` does not have side effects. Refs: nodejs#27523 PR-URL: nodejs#27684 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Showing
3 changed files
with
29 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
common.skipIfInspectorDisabled(); | ||
|
||
// Test that read-only process.env access is considered to have no | ||
// side-effects by the inspector. | ||
|
||
const assert = require('assert'); | ||
const inspector = require('inspector'); | ||
|
||
const session = new inspector.Session(); | ||
session.connect(); | ||
|
||
process.env.TESTVAR = 'foobar'; | ||
|
||
session.post('Runtime.evaluate', { | ||
expression: 'process.env.TESTVAR', | ||
throwOnSideEffect: true | ||
}, (error, res) => { | ||
assert.ifError(error); | ||
assert.deepStrictEqual(res, { | ||
result: { type: 'string', value: 'foobar' } | ||
}); | ||
}); |