fixed incorrect doctags in most_similar #601 #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. |
piskvorky
reviewed
Nov 9, 2016
| @@ -460,7 +460,7 @@ def most_similar(self, positive=[], negative=[], topn=10, clip_start=0, clip_end | |||
| return dists | |||
| best = matutils.argsort(dists, topn=topn + len(all_docs), reverse=True) | |||
| # ignore (don't return) docs from the input | |||
| result = [(self.index_to_doctag(sim), float(dists[sim])) for sim in best if sim not in all_docs] | |||
| result = [(self.index_to_doctag(sim + clip_start), float(dists[sim])) for sim in best if (sim+clip_start) not in all_docs] | |||
There was a problem hiding this comment.
PEP8: space around binary operators.
|
Made the changes mentioned above. |
tmylk
reviewed
Nov 9, 2016
| @@ -159,6 +160,12 @@ def model_sanity(self, model): | |||
| self.assertEqual(list(zip(*sims))[0], list(zip(*sims2))[0]) # same doc ids | |||
| self.assertTrue(np.allclose(list(zip(*sims))[1], list(zip(*sims2))[1])) # close-enough dists | |||
|
|
|||
| # sim results should be in clip range if given | |||
| clip_sims = model.docvecs.most_similar(fire1, clip_start=len(model.docvecs)//2, clip_end=len(model.docvecs)) | |||
There was a problem hiding this comment.
Add a clip_end as len(model.docvecs)*2//3
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most_similar() in doc2vec.py doesn't consider given clip range for tagID/indexes #601
fix: add clip_start to index_to_doctag's indexes.