Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quote of vocabulary in word2vec class #2161

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Fix quote of vocabulary in word2vec class #2161

merged 1 commit into from
Aug 27, 2018

Conversation

nzw0301
Copy link
Contributor

@nzw0301 nzw0301 commented Aug 24, 2018

Word2VecVocab did not be parsed correctly.

Before
2018-08-25 0 56 41

After
2018-08-25 1 08 44

@nzw0301 nzw0301 changed the title Fix quote in vocabulary in word2vec class Fix quote of vocabulary in word2vec class Aug 25, 2018
@piskvorky
Copy link
Owner

Well spotted, thank you @nzw0301 !

@piskvorky piskvorky requested a review from menshikh-iv August 25, 2018 15:54
@piskvorky piskvorky added bug Issue described a bug documentation Current issue related to documentation labels Aug 25, 2018
@menshikh-iv
Copy link
Contributor

Thanks @nzw0301

@menshikh-iv menshikh-iv merged commit 3ccbb2e into piskvorky:develop Aug 27, 2018
@nzw0301 nzw0301 deleted the fix-doc branch August 27, 2018 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@menshikh-iv menshikh-iv menshikh-iv approved these changes

Assignees
No one assigned
Labels
bug Issue described a bug documentation Current issue related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nzw0301 @piskvorky @menshikh-iv