Travis fix and distinct testing #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantj
reviewed
Aug 9, 2017
| @@ -118,7 +118,13 @@ echo '-------------------------------------------------------------------------- | |||
| # Excluding vec files since they contain non-utf8 content and flake8 raises exception for non-utf8 input | |||
| # We need the following command to exit with 0 hence the echo in case | |||
| # there is no match | |||
| MODIFIED_FILES="$(git diff --name-only $COMMIT_RANGE -- . ':(exclude)*.vec' || echo "no_match")" | |||
| MODIFIED_PY_FILES="$(git diff --name-only $COMMIT_RANGE | grep '[a-zA-Z0-9]*.py$' || echo "no_match")" | |||
| MODIFIED_IPYNB_FILES="$(git diff --name-only $COMMIT_RANGE | grep '[a-zA-Z0-9]*.ipynb$' || echo "no_match")" | |||
There was a problem hiding this comment.
Why have this at all? I don't see any tests performed on .ipynb files.
There was a problem hiding this comment.
I'll add it soon, it's "preparation" for testing .ipynb
jayantj
reviewed
Aug 9, 2017
| script: | ||
| - pip freeze | ||
| - python setup.py test | ||
| - pip install flake8 |
There was a problem hiding this comment.
I think we need this line in the new script.sh?
There was a problem hiding this comment.
No, because I already add it in install script
There was a problem hiding this comment.
Ah okay, I missed that, sorry.
Closed
This was referenced Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #1520 and #1518