Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent loading of IWU-dataset from slowing down the calculation #9

Open
lensum opened this issue Aug 29, 2023 · 0 comments
Open

Prevent loading of IWU-dataset from slowing down the calculation #9

lensum opened this issue Aug 29, 2023 · 0 comments

Comments

@lensum
Copy link

lensum commented Aug 29, 2023

Is your feature request related to a problem? Please describe.
When reading the TEASER examples, I found a note saying that when a new Project-instance is created, the keyword load_data=True leads to a lot of IO and thus can slow down the calculation if performed multiple times.
In the current version of the districtgenerator, in datahandler.py line 202, the Project instance is created with load_data=True and in line 214 new data is loaded by prj.add_residential(method='tabula_de', ...). I assume, that this slows down the calculation, though I haven't tested it on significance.

Describe the solution you'd like
Line 202 could be changed to read prj = Project(load_data=False).

Additional context
As I've said, I haven't tested the change yet. The effect on calculation time could be insubstantial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant