Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Quantumleap subscription as deprecated #215

Closed
tstorek opened this issue Dec 2, 2023 · 5 comments · Fixed by #263
Closed

Mark Quantumleap subscription as deprecated #215

tstorek opened this issue Dec 2, 2023 · 5 comments · Fixed by #263
Assignees

Comments

@tstorek
Copy link
Collaborator

tstorek commented Dec 2, 2023

In the current release (1.0.0) QuantumLeap no longer supports Subscription as it was just for convenience.

Look here:
orchestracities/ngsi-timeseries-api#748

Therefore, we at least need to catch the error returned and afterwards check version to return a proper Error message.
Even more, give a deprectation warning that the function will be removed in the next Versions of FiLiP.

@djs0109
Copy link
Contributor

djs0109 commented Dec 6, 2023

Besides, we should consider to change the default value of servicepaht to "/" https://github.com/RWTH-EBC/FiLiP/blob/f5f1d9fd4431b68d806e42cd494c00ad887c312e/filip/models/base.py#L86C1-L86C20. QL has already fixed that in the new release

"Fiware-servicePath was interpreted as python None, from now on, None will be replaced with /. This affects only users that manually injected data, since Orion, assume / when no servicePath is passed.."

@djs0109
Copy link
Contributor

djs0109 commented Feb 14, 2024

As mentioned in #239, this API has been removed in QL1.0.0. After testing the capability with QL1.0.0, all related code and test should be removed. Before that may be create a new tag like QL0.8.3

@djs0109
Copy link
Contributor

djs0109 commented Mar 6, 2024

ToDo list:

  • remove subscription endpoint
  • change default servcicepath to "/"
  • support idPattern as a query parameter

@djs0109 djs0109 self-assigned this Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Branch 215-Mark-Quantumleap-subscription-as-deprecated created!

@SystemsPurge
Copy link
Collaborator

I could not test whether the id_pattern parameter is working because i am not even certain it is supported in Quantumleap itself. I tried testing it but got inconsistent results.
The subscribe method of the quantumleap client is now blocked by an initial assert statment, mainly so that a well defined error could be caught when testing...
Input on how either issues can be handled in a better way is very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants