-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Quantumleap subscription as deprecated #215
Comments
Besides, we should consider to change the default value of servicepaht to "/" https://github.com/RWTH-EBC/FiLiP/blob/f5f1d9fd4431b68d806e42cd494c00ad887c312e/filip/models/base.py#L86C1-L86C20. QL has already fixed that in the new release
|
As mentioned in #239, this API has been removed in QL1.0.0. After testing the capability with QL1.0.0, all related code and test should be removed. Before that may be create a new tag like |
ToDo list:
|
Branch 215-Mark-Quantumleap-subscription-as-deprecated created! |
I could not test whether the id_pattern parameter is working because i am not even certain it is supported in Quantumleap itself. I tried testing it but got inconsistent results. |
In the current release (1.0.0) QuantumLeap no longer supports Subscription as it was just for convenience.
Look here:
orchestracities/ngsi-timeseries-api#748
Therefore, we at least need to catch the error returned and afterwards check version to return a proper Error message.
Even more, give a deprectation warning that the function will be removed in the next Versions of FiLiP.
The text was updated successfully, but these errors were encountered: