-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1171 storage spring cleaning #1226
Conversation
…SpringCleaning Corrected HTML Code in branch Correct_HTML_issue1171_StorageSpringCleaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Remove TABS changes and check comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Just the CI now ;)
…the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/ [skip ci]
…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/ [skip ci]
Errors in regression test. Compare the results on the following page |
…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/
Errors in regression test. Compare the results on the following page |
Errors in regression test. Compare the results on the following page |
@LauraMaier : Even though the plots dont show, here is the error:
|
…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/
@FWuellhorst Can you re-review? :) |
@FWuellhorst Will you be able to re-review in October? :) That would be great ! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cleaning up! Looks good!
…RWTH-EBC/AixLib into issue1171_StorageSpringCleaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feature, I will merge this now
This closes issue #1171