Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1171 storage spring cleaning #1226

Merged
merged 49 commits into from
Jul 18, 2024
Merged

Conversation

LauraMaier
Copy link
Contributor

This closes issue #1171

Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Remove TABS changes and check comments.

AixLib/Fluid/Storage/StorageDetailed.mo Outdated Show resolved Hide resolved
AixLib/Fluid/Storage/StorageDetailed.mo Outdated Show resolved Hide resolved
AixLib/Systems/TABS/BaseClasses/TabsBus.mo Outdated Show resolved Hide resolved
FWuellhorst
FWuellhorst previously approved these changes Jan 28, 2022
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just the CI now ;)

@ebc-aixlib-bot
Copy link
Contributor

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

@ebc-aixlib-bot
Copy link
Contributor

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

@ebc-aixlib-bot
Copy link
Contributor

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

@FWuellhorst
Copy link
Contributor

@LauraMaier : Even though the plots dont show, here is the error:

*** Warning: Unspecified initial conditions in 'RunScript("Resources/Scripts/Dymola/Fluid/Storage/Examples/StorageSolarCollector.mos");'.
*** Warning: Unspecified initial conditions in 'RunScript("Resources/Scripts/Dymola/Fluid/Storage/Examples/StorageBoiler.mos");'.

@LauraMaier
Copy link
Contributor Author

@FWuellhorst Can you re-review? :)

@LauraMaier
Copy link
Contributor Author

@FWuellhorst Will you be able to re-review in October? :) That would be great ! :)

FWuellhorst
FWuellhorst previously approved these changes Oct 28, 2022
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleaning up! Looks good!

@LauraMaier LauraMaier marked this pull request as draft October 31, 2022 02:53
@LauraMaier LauraMaier marked this pull request as ready for review October 31, 2022 02:53
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature, I will merge this now

@FWuellhorst FWuellhorst merged commit 559240a into main Jul 18, 2024
1 check passed
@FWuellhorst FWuellhorst deleted the issue1171_StorageSpringCleaning branch July 18, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move AixLib.Fluid.Storage.Storage in Obsolete package and rename AixLib.Fluid.Storage.BufferStorage
3 participants