Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation issues #79

Closed
peekxc opened this issue Jul 19, 2021 · 3 comments
Closed

Installation issues #79

peekxc opened this issue Jul 19, 2021 · 3 comments

Comments

@peekxc
Copy link

peekxc commented Jul 19, 2021

While compiling carma from source and installing into my system library works fine, upon trying to include the interface target in a header file I receive this error:

In file included from ../src/tallem/carma_svd.cpp:2:
/usr/local/carma/include/carma:18:12: fatal error: 'cnalloc.hpp' file not found
  #include <cnalloc.hpp>
           ^~~~~~~~~~~~~

Upon inspection, the interface target file carma looks like:

#ifndef INCLUDE_CARMA_H_
#define INCLUDE_CARMA_H_
...
#ifndef CARMA_ARMA_ALIEN_MEM_FUNCTIONS_SET
  #if defined(ARMA_VERSION_MAJOR)
    #error "carma: please include the armadillo header after the carma header or use the CARMA CMake build"
  #endif
  #include <cnalloc.hpp>
#endif
...
#include "carma_bits/nparray.h"
#include "carma_bits/arraystore.h"
#include "carma_bits/converters.h"
#endif  // INCLUDE_CARMA_H_

Shouldn't the include with cnalloc.hpp use the relative-path include pattern, like the headers at the bottom? Or is this a build configuration problem?

@conradsnicta
Copy link
Contributor

@RUrlus This indeed does look like it should be #include "carma_bits/cnalloc.hpp" instead of #include <cnalloc.hpp>

Appears to have been introduced with commit 62ac5ff

@RUrlus
Copy link
Owner

RUrlus commented Jul 19, 2021

@peekxc Thanks for reporting. You and @conradsnicta are right, I guess this slipped through CI/CD as I never test an installed version.

@RUrlus
Copy link
Owner

RUrlus commented Jul 19, 2021

@peekxc Fixed in release 9ebd5f4. @conradsnicta Thanks for the quick PR

@RUrlus RUrlus closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants