Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carma versions not set in include #78

Closed
motiwari opened this issue Jul 7, 2021 · 1 comment
Closed

Carma versions not set in include #78

motiwari opened this issue Jul 7, 2021 · 1 comment

Comments

@motiwari
Copy link

motiwari commented Jul 7, 2021

Relevant code:

carma/include/carma

Lines 39 to 41 in 7e4c54f

static constexpr unsigned int major = CARMA_VERSION_MAJOR;
static constexpr unsigned int minor = CARMA_VERSION_MINOR;
static constexpr unsigned int patch = CARMA_VERSION_PATCH;

If including the carma libraries, these lines throw an error because these variables are only set via cmake:

carma/CMakeLists.txt

Lines 3 to 5 in 7e4c54f

SET(CARMA_VERSION_MAJOR 0)
SET(CARMA_VERSION_MINOR 5)
SET(CARMA_VERSION_PATCH 0)

The error is the standard use of undefined identifier CARMA_VERSION_MAJOR etc.

Could you provide guidance on how to fix this? Running cmake does not fix the issue

@RUrlus
Copy link
Owner

RUrlus commented Jul 8, 2021

Hi @motiwari, you're right it wasn't being set unless you installed the headers using CMake or used the CMake target.
Release v0.5.1 (02a2859) contains a fix for this.

Note, if you are not building through CMake you have to include carma before armadillo. When using the CMake build you don't have this issue.

@RUrlus RUrlus closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants