PERF: Use std::move inside itkSetMacro, declare parameter non-const

Follows InsightSoftwareConsortium/ITK@e5011ae. MSVC issued C4114 warnings without it.
RTKConsortium · Jul 24, 2023 · d78d777 · d78d777
1 parent 07bcb36
commit d78d777
Showing 1 changed file with 33 additions and 26 deletions.
diff --git a/include/rtkFFTRampImageFilter.h b/include/rtkFFTRampImageFilter.h
@@ -26,20 +26,24 @@
 
 // The Set macro is redefined to clear the current FFT kernel when a parameter
 // is modified.
+// clang-format off
 #undef itkSetMacro
-#define itkSetMacro(name, type)                                                                                        \
-  virtual void Set##name(const type _arg)                                                                              \
-  {                                                                                                                    \
-    itkDebugMacro("setting " #name " to " << _arg);                                                                    \
-    CLANG_PRAGMA_PUSH                                                                                                  \
-    CLANG_SUPPRESS_Wfloat_equal if (this->m_##name != _arg)                                                            \
-    {                                                                                                                  \
-      this->m_##name = _arg;                                                                                           \
-      this->Modified();                                                                                                \
-      this->m_KernelFFT = nullptr;                                                                                     \
-    }                                                                                                                  \
-    CLANG_PRAGMA_POP                                                                                                   \
-  }
+#define itkSetMacro(name, type)                     \
+  virtual void Set##name(type _arg)           \
+  {                                                 \
+    itkDebugMacro("setting " #name " to " << _arg); \
+    CLANG_PRAGMA_PUSH                               \
+    CLANG_SUPPRESS_Wfloat_equal                     \
+    if (this->m_##name != _arg)                     \
+    {                                               \
+      this->m_##name = std::move(_arg);                        \
+      this->Modified();                             \
+      this->m_KernelFFT = nullptr;                  \
+    }                                               \
+    CLANG_PRAGMA_POP                                \
+  }                                                 \
+  ITK_MACROEND_NOOP_STATEMENT
+// clang-format on
 
 namespace rtk
 {
@@ -161,18 +165,21 @@ class ITK_TEMPLATE_EXPORT FFTRampImageFilter
 #endif
 
 // Rollback to the original definition of the Set macro
+// clang-format off
 #undef itkSetMacro
-#define itkSetMacro(name, type)                                                                                        \
-  virtual void Set##name(const type _arg)                                                                              \
-  {                                                                                                                    \
-    itkDebugMacro("setting " #name " to " << _arg);                                                                    \
-    CLANG_PRAGMA_PUSH                                                                                                  \
-    CLANG_SUPPRESS_Wfloat_equal if (this->m_##name != _arg)                                                            \
-    {                                                                                                                  \
-      this->m_##name = _arg;                                                                                           \
-      this->Modified();                                                                                                \
-    }                                                                                                                  \
-    CLANG_PRAGMA_POP                                                                                                   \
-  }
-
+#define itkSetMacro(name, type)                     \
+  virtual void Set##name(type _arg)           \
+  {                                                 \
+    itkDebugMacro("setting " #name " to " << _arg); \
+    CLANG_PRAGMA_PUSH                               \
+    CLANG_SUPPRESS_Wfloat_equal                     \
+    if (this->m_##name != _arg)                     \
+    {                                               \
+      this->m_##name = std::move(_arg);                        \
+      this->Modified();                             \
+    }                                               \
+    CLANG_PRAGMA_POP                                \
+  }                                                 \
+  ITK_MACROEND_NOOP_STATEMENT
+// clang-format on
 #endif