Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[src][ipc]add no pi flag in mutex #9359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[src][ipc]add no pi flag in mutex #9359

wants to merge 2 commits into from

Conversation

zmshahaha
Copy link
Contributor

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zmshahaha zmshahaha marked this pull request as draft August 28, 2024 08:58
@github-actions github-actions bot added the Kernel PR has src relate code label Aug 28, 2024
@zmshahaha zmshahaha force-pushed the mutex_type branch 6 times, most recently from a443c23 to bf0ef0e Compare August 30, 2024 03:32
@zmshahaha zmshahaha marked this pull request as ready for review September 14, 2024 02:39
@zmshahaha zmshahaha requested a review from Rbb666 as a code owner September 14, 2024 02:56
@polarvid
Copy link
Contributor

CI 存在异常，请确认一下原因呢

image

@zmshahaha
Copy link
Contributor Author

zmshahaha commented Sep 14, 2024 •
edited
Loading

image

看起来和我pr无关

@Rbb666 Rbb666 requested a review from polarvid September 26, 2024 05:43
polarvid
polarvid suggested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@polarvid polarvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有些问题我稍后提个补充 PR，到时一块儿来审查/合并吧。

@Rbb666
Copy link
Member

Rbb666 commented Oct 22, 2024

有些问题我稍后提个补充 PR，到时一块儿来审查/合并吧。

这个PR还有跟进吗？

@Rbb666 Rbb666 requested a review from polarvid October 22, 2024 02:19
@polarvid
Copy link
Contributor

有些问题我稍后提个补充 PR，到时一块儿来审查/合并吧。

这个PR还有跟进吗？

FYI, #9529

@mysterywolf mysterywolf reopened this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbb666 Rbb666 Awaiting requested review from Rbb666 Rbb666 is a code owner

@polarvid polarvid Awaiting requested review from polarvid

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Kernel PR has src relate code testcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmshahaha @polarvid @Rbb666 @mysterywolf