You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, in a few cases the getLicenseTitle function doesn't append a '*', which means those license strings propagate even when --unknown is passed. The ones I can spot are "Undefined", "Public Domain", "Custom: " and "UNLICENSED".
The naive solution here would be to append a '*' onto those licenses too - but I wonder if it's worth considering a refactor here. Rather than trying to detect guessed licenses, could we consider skipping the guessing functionality entirely when --unknown is passed?
The text was updated successfully, but these errors were encountered:
The
--unknown
flag is described as having the following effect:From reviewing the code, it looks like this works by appending a
*
to guessed licenses (e.g. here), and then replacing licenses that end in*
withUNKNOWN
.However, in a few cases the
getLicenseTitle
function doesn't append a '*', which means those license strings propagate even when--unknown
is passed. The ones I can spot are "Undefined", "Public Domain", "Custom: " and "UNLICENSED".The naive solution here would be to append a '*' onto those licenses too - but I wonder if it's worth considering a refactor here. Rather than trying to detect guessed licenses, could we consider skipping the guessing functionality entirely when
--unknown
is passed?The text was updated successfully, but these errors were encountered: