Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use comprehensive and descriptive commit messages with Bocklisten.md #1385

Closed
domalex opened this issue Dec 18, 2023 · 3 comments
Closed

Comments

@domalex
Copy link

domalex commented Dec 18, 2023

I find it rather difficult to follow alterations made in the Blocklisten.md file. Useful commit messages are missing most of the time. Users should easily understand what has changed and why. Otherwise it becomes a nightmare to make the required changes on their installations.

Commits for the Blocklisten.md file are in general a mess. Out of the last 4 commits there seem to be only one relevant. Useful commit messages are missing entirely:

Commits on Nov 1, 2023

@RPiList: What has changed? Everything was deleted and afterwards added again.

Commits on Dec 1, 2023

@RPiList: What has changed? Everything was deleted and afterwards added again.
@RPiList: What has changed? Everything was deleted and afterwards added again.
@LizenzFass: 2 lists were altered, 1 deleted, 1 added

@LizenzFass78851
Copy link
Contributor

I am aware that I don't necessarily document well, but to explain below which commit of the file blocklisten.md caused which changes:

Commit Description
af8b3d4 In the commit, based on #1324, the problem with the bloated lines in the display of blocklisten.md was fixed. (more information in specified hashtag number)
c4a6247 Links were updated in the commit
256ed89 98e34c6 An additional space was added after the link. What's behind it can only be explained by @RPiList

@RPiList
Copy link
Owner

RPiList commented Dec 18, 2023

Hi,

if there were no URLs added or changed by an update, they were changes of a technical matter.

For example the last update was just adding a second space character at the end of each line. That was a small problem only Firefox users experienced. Chrome is working fine with just one space.

Explaining it in detail would add too much workload for a free project like this.

Greetings.

@RPiList RPiList closed this as completed Dec 18, 2023
@domalex
Copy link
Author

domalex commented Jan 6, 2024

@RPiList We are all grateful for your initiative in providing and curating these lists.

However, If you left just a briefe message explaining the changes in your commits would help allot to keep up with the project and executing the required changes in everyone's local installation. Providing messages like @LizenzFass78851 does in his commits helps already a great deal and doesn't cost you more than a few seconds. Please reconsider. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants