-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface configuration works inconsistently #9133
Comments
That issue can be caused by using patches that affect movement of data (MLAA patch for example), not having the other data synchronization options enabled, or more likely the texture leakage mentioned in #9107. The reflection surface is detected as being corrupted and removed, so only black output is left. |
Would you like me to regress the games I have now (and in the future) with WCB+WDB+RCB+RDB in addition to the standard default config testing? |
That isn't necessary right now. I'll be doing some rewrites in a few weeks, you'll see an 'in progress' label on this ticket when that time comes. If you do want to test, you can still do so, but any bugs found must be reported here. Do not open separate issues for them. |
Merger of buffer options is done, but I first need to diagnose what is wrong with enabling both at the same time before that change can be merged. For anyone curious about testing #10119 |
With current code, text in madden still disappears, but reappears and renders correctly after a short while. This disappearance still needs investigation as it shows that some data was lost even if temporarily. Root cause is as of yet unknown. |
ACiT shows vertex buffer corruption at the great clock, a sign that invalid overwrites are happening. Likely the same phenomenon affecting Madden, more work remains to be done in write buffers code, specifically WDB in this case. |
ACiT bug is fixed with #10184 |
Madden renders correctly with WCB+WDB (with my experimental branch #10119) but RCB still causes text to disappear. This issue seems to be caused by something different. |
#10208 Documents the cause of the strange visual bugs observed in some games and tracks the implementation as well. |
Finally figured out the final piece of the puzzle. I'll need to improve communication between the surface and texture caches which are unfortunately separate due to historical reasons. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Thanks. Yes, report here if buffer options trigger bugs. |
This comment was marked as resolved.
This comment was marked as resolved.
hey there ! sorry to necro this thread but i noticed this issue in most madden games |
There are solutions, but not something an end user can easily set up on their end. Most of the solutions will bring your fps down to single digits if you tried to enable developer debug build options. Just be a little patient. Progress has been made and I hope to have it out in the next few weeks before the year comes to an end. |
#12946 Broken setting menu with WCB |
Enabling RCB causes extra graphical bug on Need for Speed The Run. WCB: WCB+RCB: This issue happens to all frostbite games. |
|
It seems that Write Color buffers causes more freezing in games prone to freezes than leaving the setting off.
I would say Dishonored also is more prone to freezes with wcb simply because accurate getllar recovers the freezes when wcb is disabled. But when enabled the freeze doesn't recover. I feel I can provide a couple logs for each of these games when they freeze. They each have varying durations but since they're prone to freezes anyways I can't guarantee the log will always contain a wcb issue rather than an issue elsewhere. Because this option alone isn't the isolated problem setting it is only the antagonist. |
#14907 should solve some of these issues. |
Sadly this PR doesn't fixes Assassin's Creed IV Black Flag when enabling WCB+RCB. |
The fix shouldn't have been to fix LLVM. |
Oh, I thought this PR was meant to fix LLVM on other games that has freezing issues with WCB+RCB, but nevermind. Also thanks for the reply. |
@kd-11 MotoGP08 seems to be fixed when RDB +WDB is enabled. you can tick the task on your tracker and maybe add pes 14/18 to the list? |
Ratchet & Clank: All 4 One breaks when Turn on all the buffers. |
In Fallout 3, turning on RCB+WCB produces graphical issues that are not present when only WCB is on. More information including screenshot and log is available here |
Hi KD-11 ! |
@Linear524 Yes, I'm just busy with other things right now but I still plan on finishing all the items eventually. |
"Ideal world conditions" are supposed to be perfect as far as emulation goes, but for some reason, games are negatively affected when they are enabled (WCB+WDB+RCB+RDB). This is because these options are rarely if ever used in combination by actual users so we don't see any bug reports for them. This is a tracker to get this issue solved.
Work items
or WDBis enabled. (Cause discovered)Finally
Blocks #9107
NOTE: If adding issues here, ignore titles that have broken SPU post-processing as that is very likely to be unrelated to the problems I am talking about. SPU post-process bug is characterized by random noisy squares on the screen with part correct visuals intersecting with incorrect/corrupt sections and will usually go away when "SPU mlaa" is disabled with a patch.
The text was updated successfully, but these errors were encountered: