Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Skipping shadows and water in Skyrim and possibly others #12987

Closed
Darkhost1999 opened this issue Nov 26, 2022 · 10 comments · Fixed by #13097
Closed

[Regression] Skipping shadows and water in Skyrim and possibly others #12987

Darkhost1999 opened this issue Nov 26, 2022 · 10 comments · Fixed by #13097
Assignees

Comments

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Nov 26, 2022

Quick summary

Since experiencing this issue with Skyrim I have tried several combinations of settings and located the build that started it all.
I wish to give a special thanks to #12977 for allowing me to load my save file and escape from White Ridge Sanctum in order for me to test this by resolving a PPU VM access violation unmapped memory violation.

Details

The issue is as shown where the regressing build has shadows and water skipping. Please inform me if the pictures aren't visible for whatever reason.
Issue not shown is that clouds, fog, dust, waterfalls are also effected.
Before and on 0.0.25-14380
image

image

After 0.0.25-14382
image

image

Build with regression

#12957

Attach two log files

Broke.log.gz
Working.log.gz

Attach capture files for visual issues

BLUS31202_20221126122440_capture.zip

System configuration

Ryzen 5 3600
GTX 1660 Super 522.25
Windows 11 beta insider

Other details

Let me know if anything doesn't work or needs reuploaded. The rsx capture looked excessively bright but showcased the issue. The screenshots is more realistic to what I saw on screen.

pull_13077._.Skyrim.BLUS31202.2022-12-15.09-12-40.mp4
@Darkhost1999 Darkhost1999 changed the title [Regression] Skipping shadows and water in Skyrim amd possibly others [Regression] Skipping shadows and water in Skyrim and possibly others Nov 26, 2022
@Darkhost1999
Copy link
Contributor Author

I'm noticing this regression only increased chances of encountering this issue not started this issue.
Testing further back the game stopped booting before finding an origin.
This is a still image not a video or a gif so it doesn't showcase the issue the same as before screenshots
image
Red indicates areas experiencing this issue after 0.0.25-14382
Blue indicates areas experiencing this issue Before and on 0.0.25-14380

Steps to reproduce teleport to the Palace of Kings in Windhelm or hitch a carriage early in gameplay and then walk straight towards any direction generally towards the inn.

@EspeonScottie
Copy link

Here's the same issue occurring in Skylanders 1, it seems to be happening only in this level plus the one before it which both happen to have a lot of water.
Capture

Log File

RPCS3.log.gz

RSX Capture

BLES01272_20221205132229_capture.zip

System Information

Intel Core i7-6700HQ
NVIDIA GeForce GTX 1060 (527.37)
Windows 10

@EspeonScottie
Copy link

So it seems the issue actually affects more than just those two levels, it also affects the Stonetown and Battlefield levels as well as portions of Creepy Citadel level. I decided to test #12960, which is the build right before #12957 and it stops occurring. So for Skylanders Spyro's Adventure at least, #12957 is the first build to cause this issue for this game. Wondering if maybe someone could a look into this and fix the rsx in the next build?

Stonetown in #12960

Stonetown (#12960)

Stonetown in #12957

Stonetown (#12957)

Attach two log files

RPCS3.log.gz (#12960)
RPCS3.log.gz (#12957)

Attach capture files for visual issues

BLES01272_20221210162502_capture.zip (#12960)
BLES01272_20221210163852_capture.zip (#12957)

System Information

Intel Core i7-6700HQ
NVIDIA GeForce GTX 1060 (527.56)
Windows 10

@kd-11 kd-11 self-assigned this Dec 11, 2022
@kd-11
Copy link
Contributor

kd-11 commented Dec 19, 2022

I forgot about this, it's a simple control flag issue.

@kd-11
Copy link
Contributor

kd-11 commented Dec 19, 2022

Should be fixed by #13097

@Darkhost1999
Copy link
Contributor Author

Works fine with PR

@Darkhost1999
Copy link
Contributor Author

Darkhost1999 commented Dec 19, 2022

Mostly works. Unfortunately I got patches in this log.
Skyrim
RPCS3.log.gz

@kd-11
Copy link
Contributor

kd-11 commented Dec 20, 2022

Check builds before the regression. This PR only addressed the regression itself. It's possible there are other bugs.
If it is reproducible a RSX capture is required.

@Darkhost1999
Copy link
Contributor Author

Darkhost1999 commented Dec 20, 2022

An RSX capture is on the PR comment I didn't know until after hitting send that you had merged it that minute.
I'm pretty sure as you said it's a separate issue as indicated in a previous comment showing pre-existing issues outlined in blue and new in red. It was also minor. I'll need to find more locations to test or a location I can actually travel to regularly.

@Darkhost1999
Copy link
Contributor Author

Got around to confirming this is something else today
Skyrim
I'll ignore unless I find it somewhere I can actually travel to. This place likely possibly was like this on the PS3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants