-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added chat name color override functionality #663
Draft
dmccoystephenson
wants to merge
27
commits into
develop
Choose a base branch
from
feature/setchatnamecolor-new
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…re/setchatnamecolor-new
…in SenderCharacterNamePart
… in ReceiverCharacterNamePart
dmccoystephenson
changed the title
Allow players to set chat name color
Added chat name color override functionality
Jul 3, 2024
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is not currently possible to set your chat name to be a different color than the chat itself.
Solution
The 'setchatnamecolor' command has been added to allow players to set their chat name color.
Testing
This was tested using the rpk-mc-server project by spinning up a minecraft server that had the rest of the RPKit suite (v2.4.0) installed. These changes have not been tested against the v2.5.x versions of the rest of the RPKit suite.
Chat name colors can now be set and persist upon a restart.
Issues
This resolves #627 and #658