Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport AOTriton 0.7b to ROCm/PyTorch's release/2.4 branch #1587

Merged
merged 12 commits into from
Sep 13, 2024
Merged

Backport AOTriton 0.7b to ROCm/PyTorch's release/2.4 branch #1587

merged 12 commits into from
Sep 13, 2024

Conversation

xinyazhang
Copy link

@xinyazhang xinyazhang commented Sep 12, 2024 •
edited by pruthvistony
Loading

It's a cherry-picked version of pytorch#134498

(WIP: need some work on the UT part)

  • [edit] Discussed with Xinya and this part is already part of current PR.

@xinyazhang
Fix cudagraph support for FA backend
dd36026
@xinyazhang
Update the AOTriton FA API to meet hipGraph demands.
c066dea
@xinyazhang
Enable test_fused_attention_vs_math_ref_grads_cudagraph and skip seq_…
14d5c60 
…len_q != seq_len_k when is_causal=True
@xinyazhang
[SDPA] Add experimental support to Navi31
4625d23
@xinyazhang
Changes aotriton_version.txt to 0.7b release
a68672b
@xinyazhang
Claim GQA is not supported on ROCM in can_use_flash_attention
06e53d0
@xinyazhang
Switch to .gz package
bc49f9a
@xinyazhang
Skip failures on test/test_native_mha.py
b3a9002
@xinyazhang
Disable Efficient attention on fp32 + is_casual=True
6d7f250
@xinyazhang
Revert "Disable Efficient attention on fp32 + is_casual=True"
10afbcf 
This reverts commit 36324a4.

It's not very effective and forcing MATH backend does not help. Need
further investigations.
@xinyazhang
Fix per suggestions from Nikita
8abad76
@xinyazhang
Fix missing 'using sdp::aotriton_adapter::mk_aoscalartensor'
99f8f42
@pruthvistony pruthvistony marked this pull request as ready for review September 13, 2024 20:29
@pruthvistony
Copy link
Collaborator

Build - http://rocm-ci.amd.com/job/mainline-framework-pytorch-2.4-ci/17/

@pruthvistony pruthvistony merged commit 83504b7 into release/2.4 Sep 13, 2024
1 check was pending
@pruthvistony pruthvistony deleted the xinyazhang/aotriton0.7b-rocmrelease2.4 branch September 13, 2024 20:30
@evshiron evshiron mentioned this pull request Sep 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruthvistony pruthvistony pruthvistony approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xinyazhang @pruthvistony