Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Look for triton.txt for triton commit after release/2.5 #64

Closed
wants to merge 1 commit into from

Conversation

jataylo
Copy link

@jataylo jataylo commented Dec 3, 2024

Since pytorch/pytorch#133438 we removed the triton-rocm.txt file but we did not update builder, this means the nightly wheels are not pulling the correct pytorch-triton-rocm version for the nightly wheels.

@jataylo
Copy link
Author

jataylo commented Dec 3, 2024

pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm6.2
Looking in indexes: https://download.pytorch.org/whl/nightly/rocm6.2
Collecting torch
Using cached https://download.pytorch.org/whl/nightly/rocm6.2/torch-2.6.0.dev20241122%2Brocm6.2-cp310-cp310-linux_x86_64.whl (3980.9 MB)
Requirement already satisfied: torchvision in /opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchvision-0.20.0a0+518ee93-py3.10-linux-x86_64.egg (0.20.0a0+518ee93)
Requirement already satisfied: torchaudio in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (2.5.0.dev20241113+rocm6.2)
Requirement already satisfied: filelock in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from torch) (3.16.1)
Requirement already satisfied: typing-extensions>=4.10.0 in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from torch) (4.12.2)
Requirement already satisfied: networkx in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from torch) (2.8.8)
Requirement already satisfied: jinja2 in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from torch) (3.1.4)
Requirement already satisfied: fsspec in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from torch) (2024.10.0)
Collecting pytorch-triton-rocm==3.1.0+cf34004b8a (from torch)
Using cached https://download.pytorch.org/whl/nightly/pytorch_triton_rocm-3.1.0%2Bcf34004b8a-cp310-cp310-linux_x86_64.whl (344.8 MB)
Requirement already satisfied: sympy==1.13.1 in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from torch) (1.13.1)
Requirement already satisfied: mpmath<1.4,>=1.1.0 in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from sympy==1.13.1->torch) (1.3.0)
Requirement already satisfied: numpy in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from torchvision) (1.24.4)
Requirement already satisfied: pillow!=8.3.*,>=5.3.0 in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from torchvision) (10.3.0)
Collecting torch
Using cached https://download.pytorch.org/whl/nightly/rocm6.2/torch-2.6.0.dev20241113%2Brocm6.2-cp310-cp310-linux_x86_64.whl (3980.9 MB)
Requirement already satisfied: MarkupSafe>=2.0 in /opt/conda/envs/py_3.10/lib/python3.10/site-packages (from jinja2->torch) (3.0.2)
Installing collected packages: pytorch-triton-rocm, torch
Successfully installed pytorch-triton-rocm-3.1.0+cf34004b8a torch-2.6.0.dev20241113+rocm6.2

@jataylo
Copy link
Author

jataylo commented Dec 3, 2024

hmm rocm6.2/6.3 have this change already. Must be needed upstream

@jataylo jataylo closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant