Skip to content

Commit

Permalink
CMake version updated to 3.22.0 (#46)
Browse files Browse the repository at this point in the history
- Choosing 3.22.0 since binary is available in pypi
- Docker image use 3.24.6 needs to be built from source
- enable_language(HIP) support is required, which is added after 3.21
  https://cmake.org/cmake/help/v3.21/command/enable_language.html
  which is currently used in tensorpipe and fbgemm-gpu.
  • Loading branch information
pruthvistony authored and jithunnair-amd committed Jul 12, 2024
1 parent f5634cf commit 542ddfb
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions manywheel/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@ RUN wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm &
rpm -ivh epel-release-latest-7.noarch.rpm && \
rm -f epel-release-latest-7.noarch.rpm

# cmake-3.18.4 from pip
RUN yum install -y python3-pip && \
python3 -mpip install cmake==3.18.4 && \
python3 -mpip install cmake==3.22.0 && \
ln -s /usr/local/bin/cmake /usr/bin/cmake

RUN yum install -y autoconf aclocal automake make
Expand Down Expand Up @@ -159,9 +158,9 @@ ENV LD_LIBRARY_PATH=/opt/rh/devtoolset-${DEVTOOLSET_VERSION}/root/usr/lib64:/opt

# cmake is already installed inside the rocm base image, so remove if present
RUN rpm -e cmake || true
# cmake-3.18.4 from pip

RUN yum install -y python3-pip && \
python3 -mpip install cmake==3.18.4 && \
python3 -mpip install cmake==3.22.0 && \
ln -s /usr/local/bin/cmake /usr/bin/cmake

# ninja
Expand Down

0 comments on commit 542ddfb

Please sign in to comment.