-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider deprecating join_abcd_scenario
and summarize_*
#468
Comments
I think that's what "deprecation" is intended for, no? |
Yeah, Let's support them for another few months, and then internalize them. |
Maybe more concretely, my question is:
I think this may be an appropriate strategy here |
I think this is exactly what |
Sounds perfect! |
Help achieved :-) thank you both. |
These functions are currently exported, but I have no idea if anybody uses them.
To some extent, it feels like we are committing ourselves to a maintenance burden for a decision made long ago.
I am curious if @jacobvjk thinks they are actively used (beyond when they are called in the body of
target_*
functions)Curious also how @AlexAxthelm and @cjyetman feel about this (not the details, but in general the process of deprecating a previously exported function)
It feels like probably a bad idea/ bad form, but want your opinions here.
AB#9903
The text was updated successfully, but these errors were encountered: