From ab62128efbe9dcebb85ed9ef56528a1ecb5db23e Mon Sep 17 00:00:00 2001 From: chrysn Date: Wed, 20 Mar 2024 19:04:12 +1000 Subject: [PATCH] CI: cargo-update from the right directory Without this change, the patch.crates-io does not take, and we are building with an old version; this primarily causes issues during version updates when the version found through patch.crates-io at runtime is recognized as the new one, but the lock file says to use the released version, and in the end cargo falls back to not using the local version. --- .github/workflows/test.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ed01f7c..e473e71 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -43,7 +43,10 @@ jobs: # and all relevant crates once, and after that, just make some notes in Cargo.lock run: | set -x - for MANIF in $(find RIOT -name Cargo.toml) + # It is important to cd in early, for otherwise the patch.crates-io + # will not catch on during the update + cd RIOT + for MANIF in $(find -name Cargo.toml) do echo "::group::Updating ${MANIF}" cargo update -p riot-sys -p riot-wrappers --aggressive --manifest-path $MANIF @@ -105,7 +108,10 @@ jobs: # and all relevant crates once, and after that, just make some notes in Cargo.lock run: | set -x - for MANIF in $(find RIOT -name Cargo.toml) + # It is important to cd in early, for otherwise the patch.crates-io + # will not catch on during the update + cd RIOT + for MANIF in $(find -name Cargo.toml) do echo "::group::Updating ${MANIF}" cargo update -p riot-sys -p riot-wrappers --aggressive --manifest-path $MANIF