Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_uhcpc: fix dependencies [gnrc_netif2-backport] #7960

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 8, 2017

#7721 showed, that posix is required to include the arpa/inet.h
header into the include path of an application using the uhcpc
module.

Additionally this PR makes the FIB an optional dependency of
gnrc_uhcpc.

Backport of #7722. It slipped through the GNRC embargo :-/...

\RIOT-OS#7721 showed, that `posix` is required to include the `arpa/inet.h`
header into the include path of an application using the `uhcpc`
module.

Additionally this PR makes the FIB an optional dependency of
`gnrc_uhcpc`.

Backport of RIOT-OS#7722
@miri64 miri64 requested a review from smlng November 8, 2017 13:51
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) GNRC Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 8, 2017
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ACK, trusting your back porting abilities 😄

@miri64
Copy link
Member Author

miri64 commented Nov 8, 2017

Errors unrelated... (gnrc_netif2_integration/master is currently broken)

@miri64 miri64 merged commit fb7fcfd into RIOT-OS:gnrc_netif2_integration/master Nov 8, 2017
@miri64 miri64 deleted the gnrc_uhcpd2/fix/7722-backport-for-gnrc_netif2 branch November 8, 2017 14:22
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants