Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_ipv6_nib: implement behavior for router discovery #7479

Merged
merged 9 commits into from
Nov 16, 2017
Merged

gnrc_ipv6_nib: implement behavior for router discovery #7479

merged 9 commits into from
Nov 16, 2017

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Aug 17, 2017 •
edited
Loading

This is the last step in my efforts to overhaul GNRC's network layer. This PR implements the router discovery part of RFCs 4861 and 6775.

TODO:

This PR is part of the network layer remodelling effort:
PR dependencies

@miri64 miri64 added GNRC Area: network Area: Networking State: waiting for other PR State: The PR requires another PR to be merged first State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Aug 17, 2017
@miri64 miri64 requested a review from cgundogan August 17, 2017 12:20
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 17, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/internal-offl' into RIOT-OS#7479
34ad348
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 17, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/pl-component' (RIOT-OS#7222) into R…
da279a2 
…IOT-OS#7479
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 17, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/ft-component' (RIOT-OS#7253) into R…
935f564 
…IOT-OS#7479
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 17, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/abr-component' (RIOT-OS#7270) into R…
5a85349 
…IOT-OS#7479
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 17, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/port-to-gnrc_netif2' into RIOT-OS#7479
11a3f2e
@miri64 miri64 force-pushed the gnrc_ipv6_nib/feat/ndp-rd branch 6 times, most recently from 1dd6bb5 to 0c83db4 Compare August 18, 2017 16:57
@miri64
Copy link
Member Author

miri64 commented Aug 18, 2017

Good news everyone: Just made a longterm test over one hop with the a border router and the NIB entries do not disappear mysteriously. So the issues revolving around that get definitely get solved with this \o/

@miri64 miri64 force-pushed the gnrc_ipv6_nib/feat/ndp-rd branch 3 times, most recently from 3cc21a5 to f78157b Compare August 21, 2017 14:53
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/pl-component' (RIOT-OS#7222) into RI…
6cea4fd 
…OT-OS#7479
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/ft-component' (RIOT-OS#7253) into RI…
d211f0d 
…OT-OS#7479
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/abr-component' (RIOT-OS#7270) into R…
c1659b5 
…IOT-OS#7479
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Merge branch 'gnrc_ipv6_nib/feat/port-to-gnrc_netif2' (RIOT-OS#7456) …
5caadd9 
…into RIOT-OS#7479
@miri64
Copy link
Member Author

miri64 commented Aug 21, 2017

Rebased and adapted to current master and current dependencies

@miri64
Copy link
Member Author

miri64 commented Aug 21, 2017

Now I can start writing the tests (tomorrow).

@miri64 miri64 force-pushed the gnrc_ipv6_nib/feat/ndp-rd branch 2 times, most recently from 9236b1d to 29f8878 Compare August 24, 2017 15:44
@miri64
Copy link
Member Author

miri64 commented Nov 15, 2017

I've fixed the errors reported by Murdock.

@miri64 miri64 dismissed bergzand’s stale review November 15, 2017 22:38

@bergzand I think this PR could need a re-ACK

@miri64 miri64 mentioned this pull request Nov 16, 2017
Merged
@miri64
Copy link
Member Author

miri64 commented Nov 16, 2017

Ping @bergzand?

@bergzand
Copy link
Member

Give me a minute to recheck :)

bergzand
bergzand requested changes Nov 16, 2017
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remark.

tests/driver_encx24j600/Makefile Outdated
@@ -5,7 +5,7 @@ FEATURES_REQUIRED = periph_spi periph_gpio

BOARD_INSUFFICIENT_MEMORY := msb-430 msb-430h nucleo32-f031 nucleo32-f042 \
nucleo32-l031 nucleo-l053 stm32f0discovery telosb \
z1
wsn430-v3_1b wsn430-v1_4 z1

USEMODULE += gnrc_netdev_default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is removed with the enc28j60 test, but not here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was an accident (but we should do that regardless as a follow-up to #7925, since those test really don't need that module).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (by removing that change from the enc28j60 test).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fine with me, as long as it is consistent between the tests.

@bergzand
Copy link
Member

Ack, ready for another round of squashing if you want to.

@bergzand
Copy link
Member

Ho, wait, murdock is failing some tests

@miri64
Copy link
Member Author

miri64 commented Nov 16, 2017

Let's rebased first. Maybe the link-issues are resolved with the inclusion of #8049.

@miri64
Copy link
Member Author

miri64 commented Nov 16, 2017

Rebased and squashed.

bergzand
bergzand reviewed Nov 16, 2017
View reviewed changes
tests/driver_encx24j600/Makefile Outdated
@@ -5,7 +5,7 @@ FEATURES_REQUIRED = periph_spi periph_gpio

BOARD_INSUFFICIENT_MEMORY := msb-430 msb-430h nucleo32-f031 nucleo32-f042 \
nucleo32-l031 nucleo-l053 stm32f0discovery telosb \
z1
wsn430-v3_1b wsn430-v1_4 z1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be wsn430-v1_3b!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (and all the other insufficient memory stuff, Murdock reported.... Why is it getting so big 😭?)

@miri64
Copy link
Member Author

miri64 commented Nov 16, 2017

Now only static tests fail :-)

@bergzand
Copy link
Member

Ack, ready for more squashing :)

@miri64
Copy link
Member Author

miri64 commented Nov 16, 2017

Squashed (hopefully for the last time)

@bergzand
Copy link
Member

Do you want to have this one merged next?

@miri64
Copy link
Member Author

miri64 commented Nov 16, 2017

Yes. Apart #7961 (which is currently not testable anyway since we can't link for any MSP430) there are no bugs left blocking this PR (unless you found one ;-)). Any further bugs that might be found through testing I would do in #7925 before merging that one (+ I want to get rid of the GNRC embargo ASAP).

@miri64 miri64 merged commit bf8465c into RIOT-OS:gnrc_netif2_integration/master Nov 16, 2017
@miri64 miri64 deleted the gnrc_ipv6_nib/feat/ndp-rd branch November 16, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cladmi cladmi cladmi left review comments

@bergzand bergzand bergzand approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees

@cgundogan cgundogan

@bergzand bergzand

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @bergzand @cladmi @cgundogan