-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc_ipv6_nib: port to gnrc_netif2 #7456
gnrc_ipv6_nib: port to gnrc_netif2 #7456
Conversation
All later PRs after #7014 in the NIB series I will port directly to |
3d16e16
to
299e1dc
Compare
Rebased and adapted to current master and current dependencies |
bd4a96a
to
1f630df
Compare
Rebased to current master and dependencies. |
1f630df
to
ba47e37
Compare
Rebased to current master and current dependencies (again...) |
Oh boy rebasing this will be .... fun... |
ba47e37
to
c906f98
Compare
Rebased to current master and dependencies. |
8bdd49f
to
a586ff0
Compare
Addressed comments |
Thanks! Should this already result in a functional gnrc_networking example? From what I've tested so far, it refuses to do ndp. |
Link-local should work with this PR, global and everything involved with routers (except routing protocols) with #7479. |
Okay, then everything behaves as expected :) You've got my ACK, code looks good to me overall, but I'm not going to claim that I have enough insight in the subtleties of the NDP code to spot the more difficult functional errors. |
Wait! I think I need to fix something I messed up in the rebase of #7424. |
Let me squash my work so far and work from there. |
0173d3f
to
256a5e8
Compare
I added two commits to fix some issues in applications I overlooked in #7424. I hope it is alright to add them here instead of adding an extra PR. |
As long as it is not yet squashed, I don't mind the extra fixes here. Makes my work easier if I can trust the CI output on these PRs again :) I have time to recheck this PR this evening. |
That won't be the case. #7414, #7417, and #7462 are also required to build properly. And there is some nasty bug in |
8f1d935
to
e5838c6
Compare
I decided to take out the application fixes after all (see #7966 for that). As I said: they won't fix the Murdock state and need some work anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Okay, still looks good and the static-test is now also (almost) happy with the PR. |
e5838c6
to
56d1f06
Compare
Squashed |
Ok. All errors seem to be unrelated. Let's merge this and fix the rest later. |
This ports the NIB to the new network interface API (since I don't want to make the unnecessary effort to port the old neighbor discovery to
gnrc_netif2
I did it this way around).Depends on
#7014(merged) and#7424(merged).This PR is part of the network layer remodelling effort: