cpu, cc2538: gpio cleanup #7320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlng
added
Type: cleanup
smlng
force-pushed
the
cpu/cc2538/gpio_cleanup
branch
from
31f57d6
to
9ef6769
Compare
smlng
force-pushed
the
cpu/cc2538/gpio_cleanup
branch
from
9ef6769
to
94b8f99
Compare
This was referenced Jul 6, 2017
smlng
added
State: WIP
|
will rebase and resolve conflicts as soon as all required PRs are merged. |
|
@A-Paul thinking about starting the review? |
A-Paul
reviewed
Jun 18, 2018
| @@ -32,6 +32,7 @@ | |||
| extern "C" { | |||
| #endif | |||
|
|
|||
| #if 0 /* USE RIOT GPIO API */ | |||
| */ | ||
| static inline int gpio_pp_num(gpio_t pin) | ||
| { | ||
| return (gpio_port_num(pin) * 8) + gpio_pin_num(pin); |
|
|
||
| #define ENABLE_DEBUG (0) | ||
| #include "debug.h" | ||
|
|
||
| /* guard this file in case no I2C device is defined */ | ||
| #if I2C_NUMOF | ||
| #ifdef I2C_NUMOF |
There was a problem hiding this comment.
For I2C_NUMOF == 0 this is also true. Does that make sense?
There was a problem hiding this comment.
no but this is changed in #9347 anyways, essentially this PR might be obsolete or at least needs major updates after the I2C rework is completed. Hence, no need for reviewing this one right now.
|
close, will rework and open new PR later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove any (okay: most) dependencies on the vendor specific (TI) gpio api, to fully embrace RIOTs own hardware independent periph gpio API.
Depends on #7310, #7313, #7316, and #7318 will resolve #6650 and makes workaround in #6773 obsolete as soon as all PRs merged.