cpu, cc2538: adapt periph uart to GPIO API #7310

smlng · 2017-07-04T09:49:04Z

this PR adapts low-level UART driver of TI CC2538 to use RIOTs GPIO API.

Its part of adaption to solve #6650, next steps are to rework I2C and SPI, too.

smlng · 2017-07-04T09:52:21Z

~~should be rebase as soon as #7303 is merged~~

smlng · 2017-07-04T12:15:04Z

rebased

smlng · 2017-07-05T07:13:43Z

~~rebased onto #7316~~

ghost

Everything looks good. I have found nothing.

smlng · 2017-11-28T21:36:06Z

rebased

PeterKietzmann · 2017-11-30T08:13:15Z

boards/remote-revb/include/periph_conf.h

@@ -26,29 +26,12 @@
 #include "cc2538_gpio.h"
 #include "periph_cpu.h"
 #include "periph_common.h"
+#include "periph/gpio.h"


I don't think so, might be an artefact from rebasing

PeterKietzmann

Minor things to clarify. Besides I've succesfully tested on remote-reva/b.

PeterKietzmann · 2017-11-30T08:20:41Z

boards/cc2538dk/include/periph_conf.h

+#define UART_0_TX_PIN       GPIO_PIN(0, 1)  /**< GPIO_PA1 */
+#define UART_0_RX_PIN       GPIO_PIN(0, 0)  /**< GPIO_PA0 */
+#define UART_0_RTS_PIN      GPIO_PIN(3, 3)  /**< GPIO_PD3 */
+#define UART_0_CTS_PIN      GPIO_PIN(1, 0)  /**< GPIO_PB0 */

 /* UART 1 device configuration */


Any ideas why this half-done configuration is here?

Nope no idea, I mean the cc2538 has 2 UARTS, but I'm not sure if both are accessible on the DK version - but should be, I'll check and maybe add the correct pin config - with RTS CTS then.

PeterKietzmann · 2017-11-30T08:24:44Z

boards/cc2538dk/include/periph_conf.h

-#define UART_0_CTS_PIN      GPIO_PB0
+#define UART_0_TX_PIN       GPIO_PIN(0, 1)  /**< GPIO_PA1 */
+#define UART_0_RX_PIN       GPIO_PIN(0, 0)  /**< GPIO_PA0 */
+#define UART_0_RTS_PIN      GPIO_PIN(3, 3)  /**< GPIO_PD3 */


In the driver implementation below it is written /* On the CC2538, hardware flow control is supported only on UART1 */ and that is also what the code represents. UART_0 however, maps to UART0 here. I'm sorry, obviously this was not intendet to fix with this PR, but could you clarify this please?

I admit I just adapted to use GPIO_PIN without questioning the general config, nor consulting the data sheet on that matter. So you mean RTS and CTS pins should be removed, right?

PeterKietzmann

Whoops, accidentally hit approve before

danpetry · 2017-12-13T16:31:59Z

Hi guys, I was just wondering if there's any movement on this? I'm changing cpu/cc2538/periph/uart.c for issue #7941 and would be good to avoid merge conflicts. I will probably be submitting a PR for this in the next few days. I could work around your changes i.e. leave the functionality you moved to the GPIO driver alone, but would be neater to merge this first if possible I think

smlng · 2017-12-13T17:15:52Z

I'll rebase to resolve conflicts, otherwise this needs approval to be merged.

danpetry · 2017-12-14T09:41:31Z

@PeterKietzmann was wondering if there would be any chance of doing this sometime in the near future? :)

smlng · 2017-12-14T09:45:32Z

rebased

PeterKietzmann · 2017-12-14T09:48:50Z

Will have an other look this afternoon

danpetry · 2017-12-14T09:49:08Z

Thx guys

PeterKietzmann

I've tested again (on a remote-revb this time) and STDIO works as expected. ACK for this change, even though my concerns about the hardware flow control configuration have not been addressed. But this is an other issue.

smlng added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jul 4, 2017

smlng self-assigned this Jul 4, 2017

smlng requested review from PeterKietzmann and A-Paul July 4, 2017 09:49

smlng added the State: waiting for other PR State: The PR requires another PR to be merged first label Jul 4, 2017

smlng added this to the Release 2017.10 milestone Jul 4, 2017

smlng force-pushed the cpu/cc2538/periph_uart branch from e3158c6 to dc7654c Compare July 4, 2017 12:14

smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Jul 4, 2017

smlng force-pushed the cpu/cc2538/periph_uart branch 5 times, most recently from b63a964 to 65876b6 Compare July 4, 2017 13:56

smlng mentioned this pull request Jul 4, 2017

cpu, cc2538: adapt periph spi to GPIO API #7313

Closed

smlng added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 5, 2017

smlng force-pushed the cpu/cc2538/periph_uart branch from 65876b6 to 99d1a40 Compare July 5, 2017 07:13

smlng added State: waiting for other PR State: The PR requires another PR to be merged first and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Jul 5, 2017

smlng requested a review from a user July 5, 2017 07:14

smlng mentioned this pull request Jul 5, 2017

cpu, cc2538: gpio cleanup #7320

Closed

ghost reviewed Jul 7, 2017

View reviewed changes

smlng force-pushed the cpu/cc2538/periph_uart branch from 99d1a40 to b41b469 Compare July 7, 2017 18:15

smlng removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jul 7, 2017

smlng force-pushed the cpu/cc2538/periph_uart branch from 1e8e0d9 to e0ff9ba Compare August 28, 2017 07:45

smlng force-pushed the cpu/cc2538/periph_uart branch 2 times, most recently from 2964321 to 9c22b13 Compare September 7, 2017 13:35

smlng modified the milestones: Release 2017.10, Release 2018.01 Nov 16, 2017

danpetry mentioned this pull request Nov 22, 2017

periph: remove dev_enums.h #7941

Closed

7 tasks

smlng force-pushed the cpu/cc2538/periph_uart branch from 9c22b13 to 04e6df7 Compare November 28, 2017 21:33

PeterKietzmann reviewed Nov 30, 2017

View reviewed changes

PeterKietzmann approved these changes Nov 30, 2017

View reviewed changes

PeterKietzmann requested changes Nov 30, 2017

View reviewed changes

cpu, cc2538: adapt uart to RIOT gpio API

ba324ef

smlng force-pushed the cpu/cc2538/periph_uart branch from 04e6df7 to a4274eb Compare December 14, 2017 09:43

smlng added 3 commits December 14, 2017 10:43

boards, remote-X: adapt and centralize uart pin config

25ef1ea

boards, cc2538dk: adapt uart pin config

0da95b0

boards, openmote: adapt uart pin config

a4274eb

smlng mentioned this pull request Dec 14, 2017

pkg: fix URL for tiny-asn1 package #8263

Merged

smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 14, 2017

PeterKietzmann approved these changes Dec 14, 2017

View reviewed changes

PeterKietzmann merged commit ec2d7c6 into RIOT-OS:master Dec 14, 2017

smlng deleted the cpu/cc2538/periph_uart branch February 6, 2018 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cpu, cc2538: adapt periph uart to GPIO API #7310

cpu, cc2538: adapt periph uart to GPIO API #7310

smlng commented Jul 4, 2017

smlng commented Jul 4, 2017 •

edited

Loading

smlng commented Jul 4, 2017

smlng commented Jul 5, 2017 •

edited

Loading

ghost left a comment

smlng commented Nov 28, 2017

PeterKietzmann Nov 30, 2017

smlng Nov 30, 2017

PeterKietzmann left a comment

PeterKietzmann Nov 30, 2017

smlng Nov 30, 2017

PeterKietzmann Nov 30, 2017

smlng Nov 30, 2017

PeterKietzmann left a comment

danpetry commented Dec 13, 2017 •

edited

Loading

smlng commented Dec 13, 2017

danpetry commented Dec 14, 2017

smlng commented Dec 14, 2017

PeterKietzmann commented Dec 14, 2017

danpetry commented Dec 14, 2017

PeterKietzmann left a comment

cpu, cc2538: adapt periph uart to GPIO API #7310

cpu, cc2538: adapt periph uart to GPIO API #7310

Conversation

smlng commented Jul 4, 2017

smlng commented Jul 4, 2017 • edited Loading

smlng commented Jul 4, 2017

smlng commented Jul 5, 2017 • edited Loading

ghost left a comment

Choose a reason for hiding this comment

smlng commented Nov 28, 2017

PeterKietzmann Nov 30, 2017

Choose a reason for hiding this comment

smlng Nov 30, 2017

Choose a reason for hiding this comment

PeterKietzmann left a comment

Choose a reason for hiding this comment

PeterKietzmann Nov 30, 2017

Choose a reason for hiding this comment

smlng Nov 30, 2017

Choose a reason for hiding this comment

PeterKietzmann Nov 30, 2017

Choose a reason for hiding this comment

smlng Nov 30, 2017

Choose a reason for hiding this comment

PeterKietzmann left a comment

Choose a reason for hiding this comment

danpetry commented Dec 13, 2017 • edited Loading

smlng commented Dec 13, 2017

danpetry commented Dec 14, 2017

smlng commented Dec 14, 2017

PeterKietzmann commented Dec 14, 2017

danpetry commented Dec 14, 2017

PeterKietzmann left a comment

Choose a reason for hiding this comment

smlng commented Jul 4, 2017 •

edited

Loading

smlng commented Jul 5, 2017 •

edited

Loading

danpetry commented Dec 13, 2017 •

edited

Loading