cpu/cc2538/periph/gpio: use bit-banding macros for thread-safe GPIO #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we clean up the K60 macros we could move it to cortexm_common since bit banding is a feature of most (all?) Cortex-M3 and M4 processors. |
PeterKietzmann
added
Area: drivers
|
Be aware of #6182 |
|
Needs a rewrite since #6182 was merged |
|
@hexluthor, any chance to have this one rebased for the next release ? |
|
I think the best solution is to rebase on top of #6916. |
|
Agree to all. Will try to deliver for this release. |
|
Ping @hexluthor |
|
Sorry, I don't have time to work on this and don't want to muck it up. If anyone would like to pick up where I left off, please feel free. |
|
Any objections to close this? |
|
I'm closing this because it's hopelessly old, but the cc2538 gpio is still not thread-safe. The gpio functions should be rewritten to call the bitband functions added in #6916. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the read-modify-write operations with bitband macros from
cpu/k60. Tested oncc2538dk.