drivers/st7735: split off separate driver modules for st7789 and st7796 #19828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To solve the repeatedly occurring dependency problems when modeling hardware options in Kconfig, the TFT hardware option is now modelled as a pseudomodule.
To solve the repeatedly occurring dependency problems when modeling hardware options in Kconfig, the TFT version of the Sipeed Longan Nano board has been split off into its own board definition based on the existing Siepeed Longan Nano board. A pseudo module is simply activated to indicate that the board has a TFT.
gschorcht
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
smlng,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: doc
Instead of using a wrong intialization command sequence for power and frame control, default values after reset are used.
gschorcht
force-pushed
the
drivers/st7735_split_into_separate
branch
from
959b216
to
f73d874
Compare
|
Closed in favor of cleaned up PR #19825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR demonstrates an alternative to PR #19825. Instead of handling the different ST77xx controller variants as pseudomodules by one driver, this PR uses a separate driver module for each variant that is simply duplicated code of
st7735. The disadvantage is that most of the code is just copied and pasted. The advantages are:Testing procedure
tests/drivers/disp_devandtests/drivers/st77xxshould still work for all boards using a ST77xx display.adafruit-pybadgeesp32s2-lilygo-ttgo-t8esp32s3-usb-otgsipeed-longan-nanoIssues/PRs references